Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

error: "failed to save" + camera-option does not work #4

Open
obacht8 opened this issue Jun 21, 2023 · 21 comments
Open

error: "failed to save" + camera-option does not work #4

obacht8 opened this issue Jun 21, 2023 · 21 comments
Assignees
Labels
bug Something isn't working

Comments

@obacht8
Copy link

obacht8 commented Jun 21, 2023

warping, cropping and preview work really nice, the app aims to provide a nice feature but does not work (least on my phone)

  1. open photo from galllery, edit ... result cannot be saved!
    error-notification: "failed to save"
  2. camera-option opens camera and pretends to take photo and that´s it: no photo anywhere

all permissions the app asks for are granted

phone: Samsung S7 SM-G930F with /e/OS 1.11

@obacht8 obacht8 changed the title error: failed to save error: "failed to save" + camera-option does not work Jun 21, 2023
@danopdev
Copy link
Owner

It's strage. It looks like the other issue:

#3

I don't know but on the device it just don't works.

@obacht8
Copy link
Author

obacht8 commented Jun 21, 2023

too bad
my custom-rom is based on Lineage OS and is Android 10 just like in the other issue, maybe that´s why...

@danopdev
Copy link
Owner

Indeed. We tried different solutions and none of them worked.
If you do find something I'll be happy to try is too.

@danopdev
Copy link
Owner

I found some possible solutions by adding more permissions.
If you have the time please try this build:

Perspective_1.18_test.apk.zip

@obacht8
Copy link
Author

obacht8 commented Jun 22, 2023

Thanks, I tried it:
There´s no additional permissions for that app to be granted in my system settings...
even though all available permissions are granted (the system only recognizes storage related permissions) the app still asks for permissions: "You must allow permissions !"
I can only confirm "OK" and the app shuts down.

@danopdev
Copy link
Owner

Thanks for trying.
Unfortunately I'm out of ideas.

@obacht8
Copy link
Author

obacht8 commented Jun 22, 2023

if another idea pops up, just let me know, happy to test it

@danopdev
Copy link
Owner

I have one last possible solution. It's ugly but at least for testing.

Perspective_1.18_test.apk.zip

@obacht8
Copy link
Author

obacht8 commented Jun 22, 2023

it works for existing photos!
ugliness might be in the code (i cannot tell) but is not visible on the surface: The UI is the same as before...

would be nice though to save the modified pictures in the same folder as the original or being able to choose the folder...

Nevertheless: choosing the camera-option (instead of choosing an already existing picture) leads to immediate shutdown of the app

@danopdev
Copy link
Owner

I think the best solution is to make the use select the output folder (and maybe change it in settings).
Saving in the save folder won't work because of rights (and Lineage OS seems to be complicate about that).

@obacht8
Copy link
Author

obacht8 commented Jun 22, 2023

yes, choosing the output-folder in settings would be OK too

about the camer-option-issue: That would not be my usecase anyway... I expect I´d normally choose existing photos anyway...

@danopdev
Copy link
Owner

Can you please try this build to make sure it works on your device too ?
Perspective_1.18_test.apk.zip

@obacht8
Copy link
Author

obacht8 commented Jun 26, 2023

  • it works for existing photos !
  • no option to choose the folder: result is stored in emulated/storage/0 ....which works for me but is not what one would expect I guess
  • camera-option: behaves like it takes a photo but it does not ... no picture anywhere to be found.

@danopdev
Copy link
Owner

Are you sure you installed the new build (I didn't changed the version).
If it's the new build in settings you must see the option in the screenshot:

Screenshot_20230627-091836

For now I'll focus on save issue. For the camera I'll try it after.

@obacht8
Copy link
Author

obacht8 commented Jun 27, 2023

Are you sure you installed the new build

no I´m not, there might have been a hickup, I´ll doublecheck this evening

@danopdev
Copy link
Owner

Save is the same issue as: #3

@danopdev danopdev self-assigned this Jun 27, 2023
@danopdev danopdev added the bug Something isn't working label Jun 27, 2023
@obacht8
Copy link
Author

obacht8 commented Jun 27, 2023

YES, destination folder can be defined in the app settings!
(it´s not evening yet but I had some spare time...)

@danopdev
Copy link
Owner

Can you please try this build for camera issue ?
Perspective_1.18_test3.apk.zip

@obacht8
Copy link
Author

obacht8 commented Jun 28, 2023 via email

@danopdev
Copy link
Owner

danopdev commented Jul 3, 2023

Well, I think I'm out of ideas.
Maybe it's related with Lineage (at least your specific version).

@obacht8
Copy link
Author

obacht8 commented Jul 3, 2023

for me it´s fine because:

  • it works for existing photos and
  • I can define where edited photos are to be saved

and that´s all I need

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

2 participants