Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #182 Support interfaces in Java and PHP #183

Merged
merged 10 commits into from
Aug 2, 2024

Conversation

mikehaertl
Copy link
Contributor

Fixes #182

@danymat This is just a stupid copy & paste work - so let me know if I missed something obvious.

If the change is fine it could probably also be added to other languages. Or is there any reason why interfaces should not be documented?

@danymat
Copy link
Owner

danymat commented Jul 25, 2024

Hello, can you make an example of interface before -> after the annotation ? Btw, thanks for your help :)

@mikehaertl
Copy link
Contributor Author

Before:

package com.example;

import java.util.UUID;
import lombok.NonNull;

public interface Entity {
    @NonNull UUID getId();
}

After:

package com.example;

import java.util.UUID;
import lombok.NonNull;

/**
 * [TODO:description]
 *
 */
public interface Entity {
    @NonNull UUID getId();
}

@mikehaertl
Copy link
Contributor Author

@danymat Is there anything I can do to resolve the problems in this branch? My changes where actually quite small, so not sure why tests ar failing now.

@danymat
Copy link
Owner

danymat commented Aug 2, 2024

Hello, tests failing are not related to you, but a bug (same as the one in lua tests) that I need to investigate and understand..
I'm merging this PR rn :)

Thanks for the PR!

@danymat danymat merged commit 88698b1 into danymat:main Aug 2, 2024
1 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support annotating interfaces
2 participants