Add julia support (second try) #185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello, thanks again for your help. That's a very good working base for julia support, and now that tests are created (thanks again), it will become easier to spot regressions if there is a need of improvement to the configuration. |
|
Glad to help with this. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have taken #84 and implemented some changes to correctly generate the docstrings. Tests for functions and structs are included.
Everything was implemented according to the guidelines from the julia documentation [0], except for the notation for optional arguments, which should be written as
foo(a [, b, c])(bandcbeing optional). This is complicated, because it is difficult (or impossible) to distinguish "optional arguments" from "keyword arguments", except for the;that is normally used in the signature to distinguish both (but that is not retrieved by tree-sitter). So instead I just placed the complete signature, which is what most of the projects I've seen does anyways.[0] https://docs.julialang.org/en/v1/manual/documentation/