Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Python bugs + added unittests #189

Merged
merged 2 commits into from
Aug 2, 2024

Conversation

ColinKennedy
Copy link
Contributor

addresses: #188

  • Adds a section in the README.md on how to run unittests
  • Python Exceptions are now grouped by type (previously it would list each duplicate)
  • A function with yield should never include Returns: (it was accidentally doing this because of type-hints)

What this PR does not include

(From the original issue)

  • typed *args / **kwargs not generating as expected

I don't know how to fix that one easily. It's still messed up.

@ColinKennedy
Copy link
Contributor Author

CI is erroring on tests/neogen/lua_emmylua_spec.lua. Not sure why. The new Python tests are working though.

@danymat
Copy link
Owner

danymat commented Aug 2, 2024

CI is erroring on tests/neogen/lua_emmylua_spec.lua. Not sure why. The new Python tests are working though.

Yup, I can't make it work. Seems like something is off with TS lua. Others seem fine though

I take a look to your PR and update you afterwards

@danymat danymat merged commit 8614bcb into danymat:main Aug 2, 2024
1 of 4 checks passed
@danymat
Copy link
Owner

danymat commented Aug 2, 2024

Thanks for the job here ! The tests are a delight

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants