forked from dOrgTech/DAOstack-collab
-
Notifications
You must be signed in to change notification settings - Fork 4
Open
Labels
AlchemydApp layer of DAOstack stackdApp layer of DAOstack stackArccontract layer of DAOstack stackcontract layer of DAOstack stackhelp wantedExtra attention is neededExtra attention is neededsubgraphcaching layer of DAOstack stackcaching layer of DAOstack stack
Description
External Token Approving Scheme
For various protocol integrations involving external tokens - like DAO treasury management, Standard Bounty network, MakerDAO vault management etc - DAO is required to approve the respective contract to spend DAO's token on its behalf. This can be achieved by calling externalTokenApproval method in the controller from new Token Approving Scheme
Scheme Specifications
- Scheme should be a universal scheme and follow the standard pattern
- Scheme should have following methods
proposeTokenApproval: This should create a new proposal by callingvcontrollerParams.intVote.Proposeand emit aNewApprovalProposalevent- _avatar: address of the DAO to which the approval is being proposed to
- _externalToken: address of the external token for which approval is required
- _spender: contract which is being proposed for the proposal
- _value: the amount to be approved
execute: This method should do required checks and then callcontroller.externalTokenApprovalmethodexecuteProposal: will be executed by votingMachine once the proposal pass or fail
Deliverables
- New scheme contract to propose for approving external token
- Subgraph mappings to index events emitted by the scheme
- Alchemy UI to interact with the scheme
Resources
Refer to our New Scheme Tutorial
Metadata
Metadata
Assignees
Labels
AlchemydApp layer of DAOstack stackdApp layer of DAOstack stackArccontract layer of DAOstack stackcontract layer of DAOstack stackhelp wantedExtra attention is neededExtra attention is neededsubgraphcaching layer of DAOstack stackcaching layer of DAOstack stack