Fixing e2e tests, podman and scheduler fail with mariner images #1450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix podman e2e install Fix scheduler start failure on standalone mariner image variant Signed-off-by: Anton Troshin <anton@diagrid.io>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release-1.14 #1450 +/- ##
================================================
- Coverage 21.86% 21.84% -0.02%
================================================
Files 40 40
Lines 4931 4934 +3
================================================
Hits 1078 1078
- Misses 3772 3775 +3
Partials 81 81 ☔ View full report in Codecov by Sentry. |
Add cleanups Remove parallel tests Fix mariner volume mount location Remove old build tags Signed-off-by: Anton Troshin <anton@diagrid.io>
JoshVanL
suggested changes
Sep 17, 2024
| @@ -50,11 +50,10 @@ jobs: | |||
| name: E2E tests for K8s (KinD) | |||
| runs-on: ubuntu-latest | |||
| env: | |||
| DAPR_RUNTIME_PINNED_VERSION: 1.13.0-rc.2 | |||
| DAPR_RUNTIME_PINNED_VERSION: 1.13.5 | |||
There was a problem hiding this comment.
Should this not be 1.14.4?
There was a problem hiding this comment.
Some tests use the latest via the DAPR_RUNTIME_LATEST_STABLE_VERSION env variable on line 55 here.
yaron2
approved these changes
Oct 1, 2024
cicoyle
pushed a commit
to cicoyle/cli
that referenced
this pull request
Oct 3, 2024
…#1450) * Fix standalone e2e tests Fix podman e2e install Fix scheduler start failure on standalone mariner image variant Signed-off-by: Anton Troshin <anton@diagrid.io> * fix test Signed-off-by: Anton Troshin <anton@diagrid.io> * revert Signed-off-by: Anton Troshin <anton@diagrid.io> * Fix podman machine settings Add cleanups Remove parallel tests Fix mariner volume mount location Remove old build tags Signed-off-by: Anton Troshin <anton@diagrid.io> --------- Signed-off-by: Anton Troshin <anton@diagrid.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix standalone e2e tests
Fix podman e2e install
Fix scheduler start failure on the standalone mariner image variant
Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #[issue number]
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: