Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add local helm repo support #1366

Closed
wants to merge 4 commits into from
Closed

Add local helm repo support #1366

wants to merge 4 commits into from

Conversation

lrascao
Copy link
Contributor

@lrascao lrascao commented Nov 21, 2023

Description

Add support for local Helm repo paths through the already existing DAPR_HELM_REPO_URL env flag. By creating two symlinks that point to charts directory of each project we're now enabled to use HEAD version of the charts.

eg.

mkdir /home/luser/dapr/helm-chart
cd /home/luser/dapr/helm-chart
ln -s ~/home/user/dapr/dashboard/chart/dapr-dashboard dapr-dashboard-latest
ln -s /home/user/dapr/core/charts/dapr dapr-latest

DAPR_HELM_REPO_URL=/home/luser/dapr/helm-charts dapr init --kubernetes --dev --wait

Issue reference

Indirectly related is https://github.com/dapr/helm-charts/issues/14, this patch lowers the testing/iteration barrier that's involved in locally testing Helm charts

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Extended the documentation

@lrascao lrascao force-pushed the add-local-helm-repo-support branch from 0623815 to d30c0b4 Compare November 21, 2023 11:46
@lrascao lrascao marked this pull request as ready for review November 21, 2023 12:02
@lrascao lrascao requested review from a team as code owners November 21, 2023 12:02
@lrascao lrascao force-pushed the add-local-helm-repo-support branch 3 times, most recently from be79c16 to ef33cf6 Compare November 24, 2023 22:52
mukundansundar
mukundansundar reviewed Nov 29, 2023
View reviewed changes
Copy link
Collaborator

@mukundansundar mukundansundar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lrascao Thanks for this contribution! Can you add an E2E for this with dapr/dapr repo helm charts pulled from local folder?

@lrascao lrascao force-pushed the add-local-helm-repo-support branch 2 times, most recently from 2838a92 to a4d7b54 Compare December 6, 2023 17:26
@lrascao
Copy link
Contributor Author

lrascao commented Dec 6, 2023

@lrascao Thanks for this contribution! Can you add an E2E for this with dapr/dapr repo helm charts pulled from local folder?

@mukundansundar added a small test that checks local helm repo installs, i used 2 .tgz files with the latest releases that i got from the helm charts repo, figured this would better that having the test rely on an external dependency to fetch them.

@codecov Codecov
Copy link

codecov bot commented Dec 13, 2023 •
edited
Loading

Codecov Report

Attention: Patch coverage is 9.67742% with 28 lines in your changes are missing coverage. Please review.

Project coverage is 22.48%. Comparing base (619cd9c) to head (0dba2c1).

Files Patch % Lines
pkg/kubernetes/kubernetes.go 0.00% 28 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #1366      +/-   ##
==========================================
- Coverage   22.55%   22.48%   -0.07%     
==========================================
  Files          40       40              
  Lines        4758     4772      +14     
==========================================
  Hits         1073     1073              
- Misses       3607     3621      +14     
  Partials       78       78

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dapr-bot
Copy link
Collaborator

This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

@dapr-bot dapr-bot added the stale label Jan 12, 2024
@dapr-bot
Copy link
Collaborator

dapr-bot commented Mar 1, 2024

This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

@dapr-bot dapr-bot added the stale label Mar 1, 2024
lrascao added 4 commits March 1, 2024 15:47
@lrascao
Refactor file path validation
c226087 
Small refactor to turn file/dir path validation more explicit.

Signed-off-by: Luis Rascao <luis.rascao@gmail.com>
@lrascao
Add support for local Helm repos
883a209 
Signed-off-by: Luis Rascao <luis.rascao@gmail.com>
@lrascao
fixup! Add support for local Helm repos
167fa7f 
Signed-off-by: Luis Rascao <luis.rascao@gmail.com>
@lrascao
Add test coverage for local Helm repo functionality
0dba2c1 
Signed-off-by: Luis Rascao <luis.rascao@gmail.com>
@lrascao
Copy link
Contributor Author

lrascao commented Mar 1, 2024

/ok-to-test

@lrascao lrascao force-pushed the add-local-helm-repo-support branch from 81fbb28 to 0dba2c1 Compare March 1, 2024 15:48
@dapr-bot dapr-bot removed the stale label Mar 1, 2024
@dapr-bot
Copy link
Collaborator

This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

@dapr-bot dapr-bot added the stale label Mar 31, 2024
@dapr-bot
Copy link
Collaborator

dapr-bot commented Apr 7, 2024

This pull request has been automatically closed because it has not had activity in the last 37 days. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

@dapr-bot dapr-bot closed this Apr 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mukundansundar mukundansundar mukundansundar left review comments

Assignees
No one assigned
Labels
stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lrascao @dapr-bot @mukundansundar