Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kubernetes installation of Prometheus lacks information about pre-requisites for using the DAPR dashboards for Grafana #3409

Closed
alexmarshall132 opened this issue May 12, 2023 · 7 comments
Assignees
Labels

Comments

@alexmarshall132
Copy link

What content needs to be created or modified?

The Grafana Dashboards for DAPR are extremely useful and they leverage metrics stored in Prometheus. Documentation around the pre-requisites for successfully using the Dashboards is lacking and should be added to improve the user's experience when getting started with monitoring DAPR-ized application.

Describe the solution you'd like

Information about the following should be added:

  • Explicit listing of the requirements for getting the Grafana Dashboards for DAPR working, specifically (but limited to):
    • The requirement for a Prometheus datasource in Grafana named "Dapr". The existing walkthrough steps name the Prometheus datasource Dapr, but don't call out the requirement for this name in order to be able to use the Grafana Dashboards out of the box.
    • The requirement for either of the following in a Kubernetes-based installation:
      • For the traditional Prometheus install, the presence of Pod and Service scrapers (with examples) that will ensure the DAPR pods and services get scraped for metrics to be collected in Prometheus.
      • For the Operator install of Prometheus, the presence of PodMonitors and ServiceMonitors for monitoring DAPR pods and services.

Where should the new material be placed?

The associated pull request from dapr/dapr, dapr/components-contrib, or other Dapr code repos

N/A

Additional context

@alexmarshall132 alexmarshall132 added the content/missing-information More information requested or needed label May 12, 2023
@alexmarshall132
Copy link
Author

Examples of Pod and Service scrapers can be found here with the names kubernetes-pods and kubernetes-services:

https://github.com/prometheus/prometheus/blob/main/documentation/examples/prometheus-kubernetes.yml

@msfussell
Copy link
Member

@alexmarshall132 Would you consider pushing a docs PR to help with this content? Thx

@observability-guy
Copy link

I would endorse @alexmarshall132 's comment.

When creating a new Prometheus Data Source in Grafana the name defaults to 'Prometheus' and I think it would be useful to add some detail as to the rationale for changing this to 'Dapr' - which, at first sight, appears to be a less intuitive option.

@hhunter-ms
Copy link
Collaborator

@alexmarshall132 following up to see if you can work on a docs PR for this?

@alexmarshall132
Copy link
Author

@alexmarshall132 following up to see if you can work on a docs PR for this?

@hhunter-ms Yes, I'll work on a docs PR for this, as soon as I've familiarized myself with this project's branching and PR processes.

@hhunter-ms
Copy link
Collaborator

@alexmarshall132 following up to see if you can work on a docs PR for this?

@hhunter-ms Yes, I'll work on a docs PR for this, as soon as I've familiarized myself with this project's branching and PR processes.

@alexmarshall132 let me know if you have any questions, I'm happy to help!

@alexmarshall132
Copy link
Author

New material has already been added, closing this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants