clean up

Signed-off-by: Elena Kolevska <elena@kolevska.com>

Author: elena-kolevska

dapr/clients/grpc/client.py

@@ -483,6 +483,18 @@ def publish_event(
         return DaprResponse(call.initial_metadata())
 
     def subscribe(self, pubsub_name, topic, metadata=None, dead_letter_topic=None):
+        """
+        Subscribe to a topic with a bidirectional stream
+
+        Args:
+            pubsub_name (str): The name of the pubsub component.
+            topic (str): The name of the topic.
+            metadata (Optional[Dict]): Additional metadata for the subscription.
+            dead_letter_topic (Optional[str]): Name of the dead-letter topic.
+
+        Returns:
+            Subscription: The Subscription object managing the stream.
+        """
         subscription = Subscription(self._stub, pubsub_name, topic, metadata, dead_letter_topic)
         subscription.start()
         return subscription

tests/clients/fake_dapr_server.py

@@ -205,8 +205,6 @@ def SubscribeTopicEventsAlpha1(self, request_iterator, context):
             spec_version='1.0',
         )
         yield api_v1.SubscribeTopicEventsResponseAlpha1(event_message=msg3)
-        # Simulate the stream being closed with an error
-        context.abort(grpc.StatusCode.CANCELLED, 'Stream closed by server')
 
     def SaveState(self, request, context):
         self.check_for_exception(context)

tests/clients/test_dapr_grpc_client.py

@@ -266,7 +266,7 @@ def test_subscribe_topic(self):
         dapr = DaprGrpcClient(f'{self.scheme}localhost:{self.grpc_port}')
         subscription = dapr.subscribe(pubsub_name='pubsub', topic='example')
 
-        # First message
+        # First message - text
         message1 = subscription.next_message()
         subscription.respond_success(message1)
 
@@ -281,7 +281,7 @@ def test_subscribe_topic(self):
         self.assertEqual('text/plain', message1.data_content_type())
         self.assertEqual('hello2', message1.data())
 
-        # Second message
+        # Second message - json
         message2 = subscription.next_message()
         subscription.respond_success(message2)