Improve tests for health servicer

Signed-off-by: Yevgen Polyak <yevgen.polyak@gmail.com>

Author: evhen14

ext/dapr-ext-grpc/dapr/ext/grpc/_health_servicer.py

@@ -4,7 +4,7 @@
 from dapr.proto import appcallback_service_v1
 from dapr.proto.runtime.v1.appcallback_pb2 import HealthCheckResponse
 
-HealthCheckCallable = Callable[[], None]
+HealthCheckCallable = Optional[Callable[[], None]]
 
 
 class _HealthCheckServicer(appcallback_service_v1.AppCallbackHealthCheckServicer):
@@ -13,19 +13,19 @@ class _HealthCheckServicer(appcallback_service_v1.AppCallbackHealthCheckServicer
     :class:`App` provides useful decorators to register method, topic, input bindings.
     """
 
+    def __init__(self):
+        self._health_check_cb: Optional[HealthCheckCallable] = None
+
     def register_health_check(self, cb: HealthCheckCallable) -> None:
         if not cb:
             raise ValueError('health check callback must be defined')
         self._health_check_cb = cb
 
-    def __init__(self):
-        self._health_check_cb: Optional[HealthCheckCallable] = None
-
     def HealthCheck(self, request, context):
         """Health check."""
 
         if not self._health_check_cb:
-            context.set_code(grpc.StatusCode.UNIMPLEMENTED)
+            context.set_code(grpc.StatusCode.UNIMPLEMENTED)  # type: ignore
             context.set_details('Method not implemented!')
             raise NotImplementedError('Method not implemented!')
         self._health_check_cb()

ext/dapr-ext-grpc/dapr/ext/grpc/app.py

@@ -20,7 +20,7 @@
 
 from dapr.conf import settings
 from dapr.ext.grpc._servicer import _CallbackServicer, Rule  # type: ignore
-from dapr.ext.grpc._health_servicer import _HealthCheckServicer
+from dapr.ext.grpc._health_servicer import _HealthCheckServicer  # type: ignore
 from dapr.proto import appcallback_service_v1
 
 

ext/dapr-ext-grpc/tests/test_health_servicer.py

@@ -0,0 +1,20 @@
+import unittest
+from unittest.mock import MagicMock
+
+from dapr.ext.grpc._health_servicer import _HealthCheckServicer
+
+
+class OnInvokeTests(unittest.TestCase):
+    def setUp(self):
+        self._health_servicer = _HealthCheckServicer()
+
+    def test_healthcheck_cb_called(self):
+        health_cb = MagicMock()
+        self._health_servicer.register_health_check(health_cb)
+        self._health_servicer.HealthCheck(None, MagicMock())
+        health_cb.assert_called_once()
+
+    def test_no_healthcheck_cb(self):
+        with self.assertRaises(NotImplementedError) as exception_context:
+            self._health_servicer.HealthCheck(None, MagicMock())
+        self.assertIn('Method not implemented!', exception_context.exception.args[0])

ext/dapr-ext-grpc/tests/test_servicier.py

@@ -19,18 +19,18 @@
 
 from dapr.clients.grpc._request import InvokeMethodRequest
 from dapr.clients.grpc._response import InvokeMethodResponse, TopicEventResponse
-from dapr.ext.grpc._servicier import _CallbackServicer
+from dapr.ext.grpc._servicer import _CallbackServicer
 from dapr.proto import common_v1, appcallback_v1
 
 from google.protobuf.any_pb2 import Any as GrpcAny
 
 
 class OnInvokeTests(unittest.TestCase):
     def setUp(self):
-        self._servicier = _CallbackServicer()
+        self._servicer = _CallbackServicer()
 
     def _on_invoke(self, method_name, method_cb):
-        self._servicier.register_method(method_name, method_cb)
+        self._servicer.register_method(method_name, method_cb)
 
         # fake context
         fake_context = MagicMock()
@@ -39,7 +39,7 @@ def _on_invoke(self, method_name, method_cb):
             ('key2', 'value1'),
         )
 
-        return self._servicier.OnInvoke(
+        return self._servicer.OnInvoke(
             common_v1.InvokeRequest(method=method_name, data=GrpcAny()),
             fake_context,
         )
@@ -93,18 +93,18 @@ def method_cb(request: InvokeMethodRequest):
 
 class TopicSubscriptionTests(unittest.TestCase):
     def setUp(self):
-        self._servicier = _CallbackServicer()
+        self._servicer = _CallbackServicer()
         self._topic1_method = Mock()
         self._topic2_method = Mock()
         self._topic3_method = Mock()
         self._topic3_method.return_value = TopicEventResponse('success')
         self._topic4_method = Mock()
 
-        self._servicier.register_topic('pubsub1', 'topic1', self._topic1_method, {'session': 'key'})
-        self._servicier.register_topic('pubsub1', 'topic3', self._topic3_method, {'session': 'key'})
-        self._servicier.register_topic('pubsub2', 'topic2', self._topic2_method, {'session': 'key'})
-        self._servicier.register_topic('pubsub2', 'topic3', self._topic3_method, {'session': 'key'})
-        self._servicier.register_topic(
+        self._servicer.register_topic('pubsub1', 'topic1', self._topic1_method, {'session': 'key'})
+        self._servicer.register_topic('pubsub1', 'topic3', self._topic3_method, {'session': 'key'})
+        self._servicer.register_topic('pubsub2', 'topic2', self._topic2_method, {'session': 'key'})
+        self._servicer.register_topic('pubsub2', 'topic3', self._topic3_method, {'session': 'key'})
+        self._servicer.register_topic(
             'pubsub3',
             'topic4',
             self._topic4_method,
@@ -121,12 +121,12 @@ def setUp(self):
 
     def test_duplicated_topic(self):
         with self.assertRaises(ValueError):
-            self._servicier.register_topic(
+            self._servicer.register_topic(
                 'pubsub1', 'topic1', self._topic1_method, {'session': 'key'}
             )
 
     def test_list_topic_subscription(self):
-        resp = self._servicier.ListTopicSubscriptions(None, None)
+        resp = self._servicer.ListTopicSubscriptions(None, None)
         self.assertEqual('pubsub1', resp.subscriptions[0].pubsub_name)
         self.assertEqual('topic1', resp.subscriptions[0].topic)
         self.assertEqual({'session': 'key'}, resp.subscriptions[0].metadata)
@@ -143,23 +143,23 @@ def test_list_topic_subscription(self):
         self.assertEqual({'session': 'key'}, resp.subscriptions[4].metadata)
 
     def test_topic_event(self):
-        self._servicier.OnTopicEvent(
+        self._servicer.OnTopicEvent(
             appcallback_v1.TopicEventRequest(pubsub_name='pubsub1', topic='topic1'),
             self.fake_context,
         )
 
         self._topic1_method.assert_called_once()
 
     def test_topic3_event_called_once(self):
-        self._servicier.OnTopicEvent(
+        self._servicer.OnTopicEvent(
             appcallback_v1.TopicEventRequest(pubsub_name='pubsub1', topic='topic3'),
             self.fake_context,
         )
 
         self._topic3_method.assert_called_once()
 
     def test_topic3_event_response(self):
-        response = self._servicier.OnTopicEvent(
+        response = self._servicer.OnTopicEvent(
             appcallback_v1.TopicEventRequest(pubsub_name='pubsub1', topic='topic3'),
             self.fake_context,
         )
@@ -169,7 +169,7 @@ def test_topic3_event_response(self):
         )
 
     def test_disable_topic_validation(self):
-        self._servicier.OnTopicEvent(
+        self._servicer.OnTopicEvent(
             appcallback_v1.TopicEventRequest(pubsub_name='pubsub3', topic='should_be_ignored'),
             self.fake_context,
         )
@@ -178,20 +178,20 @@ def test_disable_topic_validation(self):
 
     def test_non_registered_topic(self):
         with self.assertRaises(NotImplementedError):
-            self._servicier.OnTopicEvent(
+            self._servicer.OnTopicEvent(
                 appcallback_v1.TopicEventRequest(pubsub_name='pubsub1', topic='topic_non_existed'),
                 self.fake_context,
             )
 
 
 class BindingTests(unittest.TestCase):
     def setUp(self):
-        self._servicier = _CallbackServicer()
+        self._servicer = _CallbackServicer()
         self._binding1_method = Mock()
         self._binding2_method = Mock()
 
-        self._servicier.register_binding('binding1', self._binding1_method)
-        self._servicier.register_binding('binding2', self._binding2_method)
+        self._servicer.register_binding('binding1', self._binding1_method)
+        self._servicer.register_binding('binding2', self._binding2_method)
 
         # fake context
         self.fake_context = MagicMock()
@@ -202,15 +202,15 @@ def setUp(self):
 
     def test_duplicated_binding(self):
         with self.assertRaises(ValueError):
-            self._servicier.register_binding('binding1', self._binding1_method)
+            self._servicer.register_binding('binding1', self._binding1_method)
 
     def test_list_bindings(self):
-        resp = self._servicier.ListInputBindings(None, None)
+        resp = self._servicer.ListInputBindings(None, None)
         self.assertEqual('binding1', resp.bindings[0])
         self.assertEqual('binding2', resp.bindings[1])
 
     def test_binding_event(self):
-        self._servicier.OnBindingEvent(
+        self._servicer.OnBindingEvent(
             appcallback_v1.BindingEventRequest(name='binding1'),
             self.fake_context,
         )
@@ -219,7 +219,7 @@ def test_binding_event(self):
 
     def test_non_registered_binding(self):
         with self.assertRaises(NotImplementedError):
-            self._servicier.OnBindingEvent(
+            self._servicer.OnBindingEvent(
                 appcallback_v1.BindingEventRequest(name='binding3'),
                 self.fake_context,
             )