Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Adds support for the DAPR_GRPC_ENDPOINT env variable for workflows #610

Merged

Conversation

elena-kolevska
Copy link
Contributor

Description

If the DAPR_GRPC_ENDPOINT is present and no arguments have been passed to the

Issue reference

#609

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Extended the documentation

Signed-off-by: Elena Kolevska <elena@kolevska.com>
@elena-kolevska elena-kolevska marked this pull request as ready for review October 9, 2023 13:39
@elena-kolevska elena-kolevska requested review from a team as code owners October 9, 2023 13:39
@elena-kolevska elena-kolevska changed the title feat: Adds support for the DAPR_GRPC_ENDPOINT env variable feat: Adds support for the DAPR_GRPC_ENDPOINT env variable for workflows Oct 27, 2023
Copy link

codecov bot commented Oct 31, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (690ac99) 86.13% compared to head (fdfe612) 86.49%.

❗ Current head fdfe612 differs from pull request most recent head a779bab. Consider uploading reports for the commit a779bab to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #610      +/-   ##
==========================================
+ Coverage   86.13%   86.49%   +0.35%     
==========================================
  Files          74       75       +1     
  Lines        3700     3628      -72     
==========================================
- Hits         3187     3138      -49     
+ Misses        513      490      -23     
Files Coverage Δ
ext/dapr-ext-workflow/dapr/ext/workflow/util.py 100.00% <100.00%> (ø)
ext/dapr-ext-workflow/tests/test_workflow_util.py 100.00% <100.00%> (ø)

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@berndverst berndverst merged commit 7e3704d into dapr:master Oct 31, 2023
7 of 11 checks passed
@berndverst
Copy link
Member

@elena-kolevska it turns out this broke the workflow example.

@elena-kolevska
Copy link
Contributor Author

Fixed in #632

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants