From 21caf4be95ae61c54fcd506cd7f2f1fbf5898f5d Mon Sep 17 00:00:00 2001 From: Marc Duiker Date: Wed, 29 Jan 2025 14:22:35 +0100 Subject: [PATCH 1/6] Fix inconsistent multi-app run files Signed-off-by: Marc Duiker --- jobs/go/http/README.md | 38 ++++++++-------- jobs/go/http/dapr.yaml | 8 ++-- jobs/go/sdk/README.md | 46 ++++++++++---------- jobs/go/sdk/dapr.yaml | 8 ++-- pub_sub/csharp/sdk/README.md | 26 +++++------ pub_sub/csharp/sdk/dapr.yaml | 2 +- pub_sub/go/sdk/README.md | 24 +++++----- pub_sub/go/sdk/dapr.yaml | 2 +- pub_sub/javascript/sdk/README.md | 22 +++++----- pub_sub/javascript/sdk/dapr.yaml | 2 +- service_invocation/csharp/http/dapr.yaml | 4 +- service_invocation/go/http/dapr.yaml | 4 +- service_invocation/java/http/dapr.yaml | 4 +- service_invocation/javascript/http/dapr.yaml | 4 +- service_invocation/python/http/dapr.yaml | 4 +- workflows/go/sdk/dapr.yaml | 4 +- workflows/java/sdk/dapr.yaml | 2 +- workflows/javascript/sdk/dapr.yaml | 2 +- workflows/python/sdk/dapr.yaml | 4 +- 19 files changed, 105 insertions(+), 105 deletions(-) diff --git a/jobs/go/http/README.md b/jobs/go/http/README.md index 67233bab8..0fb48e4e4 100644 --- a/jobs/go/http/README.md +++ b/jobs/go/http/README.md @@ -20,11 +20,11 @@ Open a new terminal window and run the multi app run template: @@ -83,7 +83,7 @@ dapr stop -f . 1. Open a terminal and run the `job-service` app: ```bash -dapr run --app-id job-service --app-port 6200 --dapr-http-port 6280 -- go run . +dapr run --app-id job-service-http --app-port 6200 --dapr-http-port 6280 -- go run . ``` 2. On a new terminal window, schedule the `R2-D2` Job using the Jobs API. @@ -104,9 +104,9 @@ curl -X POST \ Back at the `job-service` app terminal window, the output should be: ```text -== APP - job-app == Received job request... -== APP - job-app == Starting droid: R2-D2 -== APP - job-app == Executing maintenance job: Oil Change +== APP - job-service-http == Received job request... +== APP - job-service-http == Starting droid: R2-D2 +== APP - job-service-http == Executing maintenance job: Oil Change ``` 3. On the same terminal window, schedule the `C-3PO` Job using the Jobs API. @@ -155,5 +155,5 @@ curl -X GET http://localhost:6280/v1.0-alpha1/jobs/c-3po -H "Content-Type: appli Back at the `job-service` app terminal window, the output should be: ```text -ERRO[0249] Error getting job c-3po due to: rpc error: code = Unknown desc = job not found: app||default||job-service||c-3po instance=diagrid.local scope=dapr.api type=log ver=1.14.0-rc.2 +ERRO[0249] Error getting job c-3po due to: rpc error: code = Unknown desc = job not found: app||default||job-service-http||c-3po instance=diagrid.local scope=dapr.api type=log ver=1.14.0-rc.2 ``` diff --git a/jobs/go/http/dapr.yaml b/jobs/go/http/dapr.yaml index d3edf24ab..a3228f2fb 100644 --- a/jobs/go/http/dapr.yaml +++ b/jobs/go/http/dapr.yaml @@ -1,13 +1,13 @@ version: 1 apps: - - appDirPath: ./job-service/ - appID: job-service + - appID: job-service-http + appDirPath: ./job-service/ appPort: 6200 daprHTTPPort: 6280 schedulerHostAddress: localhost command: ["go", "run", "."] - - appDirPath: ./job-scheduler/ - appID: job-scheduler + - appID: job-scheduler-http + appDirPath: ./job-scheduler/ appPort: 6300 daprHTTPPort: 6380 command: ["go", "run", "."] diff --git a/jobs/go/sdk/README.md b/jobs/go/sdk/README.md index 0938ebd7e..91c7936ac 100644 --- a/jobs/go/sdk/README.md +++ b/jobs/go/sdk/README.md @@ -20,10 +20,10 @@ Open a new terminal window and run the multi app run template: @@ -99,7 +99,7 @@ dapr stop -f . 1. Open a terminal and run the `job-service` app: ```bash -dapr run --app-id job-service --app-port 6400 --dapr-grpc-port 6481 --app-protocol grpc -- go run . +dapr run --app-id job-service-sdk --app-port 6400 --dapr-grpc-port 6481 --app-protocol grpc -- go run . ``` The output should be: @@ -115,7 +115,7 @@ The output should be: 2. On a new terminal window, run the `job-scheduler` app: ```bash -dapr run --app-id job-scheduler --app-port 6500 -- go run . +dapr run --app-id job-scheduler-sdk --app-port 6500 -- go run . ``` The output should be: diff --git a/jobs/go/sdk/dapr.yaml b/jobs/go/sdk/dapr.yaml index 82f18f4e4..83f61d8b6 100644 --- a/jobs/go/sdk/dapr.yaml +++ b/jobs/go/sdk/dapr.yaml @@ -3,14 +3,14 @@ common: daprdLogDestination: console logLevel: info apps: - - appDirPath: ./job-service/ - appID: job-service + - appID: job-service-sdk + appDirPath: ./job-service/ appPort: 6400 daprGRPCPort: 6481 appProtocol: grpc schedulerHostAddress: localhost command: ["go", "run", "."] - - appDirPath: ./job-scheduler/ - appID: job-scheduler + - appID: job-scheduler-sdk + appDirPath: ./job-scheduler/ appPort: 6500 command: ["go", "run", "."] diff --git a/pub_sub/csharp/sdk/README.md b/pub_sub/csharp/sdk/README.md index 199b72af3..ebd6b51b3 100644 --- a/pub_sub/csharp/sdk/README.md +++ b/pub_sub/csharp/sdk/README.md @@ -23,7 +23,7 @@ This section shows how to run both applications at once using [multi-app run tem diff --git a/pub_sub/go/sdk/dapr.yaml b/pub_sub/go/sdk/dapr.yaml index 2290474b3..cdf895022 100644 --- a/pub_sub/go/sdk/dapr.yaml +++ b/pub_sub/go/sdk/dapr.yaml @@ -2,7 +2,7 @@ version: 1 common: resourcesPath: ../../components/ apps: - - appID: order-processor + - appID: order-processor-sdk appDirPath: ./order-processor/ appPort: 6005 command: ["go", "run", "."] diff --git a/pub_sub/javascript/sdk/README.md b/pub_sub/javascript/sdk/README.md index 91dfd1a8d..fcd37826d 100644 --- a/pub_sub/javascript/sdk/README.md +++ b/pub_sub/javascript/sdk/README.md @@ -39,7 +39,7 @@ cd ..