Prevent crashing when display tv show/movie details

Author: darkalfx

Requestrr.WebApi/RequestrrBot/ChatClients/Discord/DiscordMovieRequestingWorkFlow.cs

@@ -81,7 +81,7 @@ public async Task<MovieSelection> GetMovieSelectionAsync(IReadOnlyList<Movie> mo
                 var movieRow = new StringBuilder();
                 movieRow.Append($"{i + 1}) {arrayMovies[i].Title} ");
 
-                if (!string.IsNullOrWhiteSpace(arrayMovies[i].ReleaseDate))
+                if (!string.IsNullOrWhiteSpace(arrayMovies[i].ReleaseDate) && arrayMovies[i].ReleaseDate.Length >= 4)
                     movieRow.Append($"({arrayMovies[i].ReleaseDate.Substring(0, 4)}) ");
 
                 movieRow.Append($"[[TheMovieDb](https://www.themoviedb.org/movie/{arrayMovies[i].TheMovieDbId})]");
@@ -147,13 +147,17 @@ public async Task DisplayMovieDetails(Movie movie)
         public static async Task<Embed> GenerateMovieDetailsAsync(Movie movie, SocketUser user, IMovieSearcher movieSearcher = null)
         {
             var embedBuilder = new EmbedBuilder()
-                .WithTitle($"{movie.Title} {(!string.IsNullOrWhiteSpace(movie.ReleaseDate) ? $"({movie.ReleaseDate.Split("T")[0].Substring(0, 4)})" : string.Empty)}")
-                .WithDescription(movie.Overview.Substring(0, Math.Min(movie.Overview.Length, 255)) + "(...)")
+                .WithTitle($"{movie.Title} {(!string.IsNullOrWhiteSpace(movie.ReleaseDate) && movie.ReleaseDate.Length >= 4 ? $"({movie.ReleaseDate.Split("T")[0].Substring(0, 4)})" : string.Empty)}")
                 .WithFooter(user.Username, $"https://cdn.discordapp.com/avatars/{user.Id.ToString()}/{user.AvatarId}.png")
                 .WithTimestamp(DateTime.Now)
                 .WithUrl($"https://www.themoviedb.org/movie/{movie.TheMovieDbId}")
                 .WithThumbnailUrl("https://i.imgur.com/44ueTES.png");
 
+            if(!string.IsNullOrWhiteSpace(movie.Overview))
+            {
+                embedBuilder.WithDescription(movie.Overview.Substring(0, Math.Min(movie.Overview.Length, 255)) + "(...)");
+            }
+
             if (!string.IsNullOrEmpty(movie.PosterPath) && movie.PosterPath.StartsWith("http", StringComparison.InvariantCultureIgnoreCase)) embedBuilder.WithImageUrl(movie.PosterPath);
             if (!string.IsNullOrWhiteSpace(movie.Quality)) embedBuilder.AddField("__Quality__", $"{movie.Quality}p", true);
             if (!string.IsNullOrWhiteSpace(movie.PlexUrl)) embedBuilder.AddField("__Plex__", $"[Watch now]({movie.PlexUrl})", true);

Requestrr.WebApi/RequestrrBot/ChatClients/Discord/DiscordTvShowsRequestingWorkFlow.cs

@@ -147,19 +147,26 @@ public static Embed GenerateTvShowDetailsAsync(TvShow tvShow, SocketUser user)
         {
             var title = tvShow.Title;
 
-            if (!string.IsNullOrWhiteSpace(tvShow.FirstAired) && !title.Contains(tvShow.FirstAired.Split("T")[0].Substring(0, 4)))
+            if (!string.IsNullOrWhiteSpace(tvShow.FirstAired))
             {
-                title = $"{title} ({tvShow.FirstAired.Split("T")[0].Substring(0, 4)})";
+                if(tvShow.FirstAired.Length >= 4 && !title.Contains(tvShow.FirstAired.Split("T")[0].Substring(0, 4)))
+                {
+                    title = $"{title} ({tvShow.FirstAired.Split("T")[0].Substring(0, 4)})";
+                }
             }
 
             var embedBuilder = new EmbedBuilder()
                 .WithTitle(title)
-                .WithDescription(tvShow.Overview.Substring(0, Math.Min(tvShow.Overview.Length, 255)) + "(...)")
                 .WithFooter(user.Username, $"https://cdn.discordapp.com/avatars/{user.Id}/{user.AvatarId}.png")
                 .WithTimestamp(DateTime.Now)
                 .WithUrl($"https://www.thetvdb.com/?id={tvShow.TheTvDbId}&tab=series")
                 .WithThumbnailUrl("https://thetvdb.com/images/logo.png");
 
+            if(!string.IsNullOrWhiteSpace(tvShow.Overview))
+            {
+                embedBuilder.WithDescription(tvShow.Overview.Substring(0, Math.Min(tvShow.Overview.Length, 255)) + "(...)");
+            }
+
             if (!string.IsNullOrEmpty(tvShow.Banner) && tvShow.Banner.StartsWith("http", StringComparison.InvariantCultureIgnoreCase)) embedBuilder.WithImageUrl(tvShow.Banner);
             if (!string.IsNullOrWhiteSpace(tvShow.Network)) embedBuilder.AddField("__Network__", tvShow.Network, true);
             if (!string.IsNullOrWhiteSpace(tvShow.Status)) embedBuilder.AddField("__Status__", tvShow.Status, true);