Skip to content

[ReviewViewer] Struggling to compile source code #597

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tetj2 opened this issue Dec 17, 2024 · 6 comments
Open

[ReviewViewer] Struggling to compile source code #597

tetj2 opened this issue Dec 17, 2024 · 6 comments
Labels
bug Something isn't working

Comments

@tetj2
Copy link

tetj2 commented Dec 17, 2024

Extension name

ReviewViewer

Bug Description

Hi Brandon,

I'm a software developer so I'm usually pretty good at this stuff but I struggle to get it to compile with VS 2022 and PlayniteExtensions.sln.
I tried to download the latest release but there are a lot of errors like this line is missing the second parameter at the end.
var downloadOptions = new VideoDownloadOptions(VideoType.Trailer,);
Aside from that, there are a lot of mising assemblies.
I tried to fix some with nuget but I'm starting to wonder, should I be using an older release or am I missing something ?

On the plus side, I was able to compile ReviewViewer by loading the .sln of that solution.

Thank you,
Jp

To Reproduce

No response

Logs

.

Screenshots

No response

@tetj2 tetj2 added the bug Something isn't working label Dec 17, 2024
@tetj2
Copy link
Author

tetj2 commented Dec 18, 2024

FYI, I came up with a few ideas, still working on it :
https://www.reddit.com/r/playnite/comments/1bi86xm/comment/m24sdj3/?context=3

@darklinkpower
Copy link
Owner

I'm a little confused, are the compilation issues for ReviewsViewer or another extension? Because var downloadOptions = new VideoDownloadOptions(VideoType.Trailer,); should be part of Extra Metadata Loader if I'm correct. If that's the case, currently it won't compile because I'm rewriting and refactoring the extension and it's unfinished. To compile it you'll need to use a commit before this one:

image

@tetj
Copy link

tetj commented Jan 26, 2025

Hi Brandon,

It seems the issue was that I was trying to compile the whole PlayniteExtensions.sln at once.
Now I'm opening plugins .sln individually and it works ;)

I've been working on and off my Playnite library for the past month.
I've made some changes to your plugins for myself ...
I've started sharing these changes with you, if they can be of any use ...
Since I had simply downloaded the source code instead of forking, it's a bit complicated, it's a bad habit I have ;p
Here is one : https://github.com/tetj/PlayniteExtensionsCollection/tree/patch-1
I'll try to make a few like that one ...
Please let me know if you prefer that I do it differently ...

Thank you,
Jp

@tetj
Copy link

tetj commented Jan 27, 2025

FYI, I started a theme and an extension to share my changes.
Here is the documentation for it so far : https://github.com/tetj/BonusTools/blob/master/documentation/Playnite.docx?raw=1

@tetj
Copy link

tetj commented Jan 28, 2025

btw, if you are looking for work or a side job, I'm in Canada and I've a friend who has a few employees, he is looking for C# programmers, it can be done remotely and part time. I've been looking at your code and it's sharp ;)

@tetj
Copy link

tetj commented Jan 28, 2025

Btw, I think it would be nice if you could do something like this to show how your Extensions are used in your Themes :

Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants