Skip to content

Middle grey and white patches index inverted in COLOR_CHECKER_SPYDER_48 #20764

@Cobert0

Description

@Cobert0

Is there an existing issue for this?

  • I checked and did not find my issue in the already reported ones

Describe the bug

In the file /common/colorchecker.h, index of "white" is 21 instead 24 and "middle_grey" is 24 instead 21.
White = 1E, middle_grey = 4D on the chart:
https://www.datacolor.com/spyder/downloads/SpyderCheckr_Color_Data_V2.pdf.

Steps to reproduce

Look on file colorchecker.h

Expected behavior

No response

Logfile | Screenshot | Screencast

colorchecker.h
dt_color_checker_t spyder_48 = { .name = "Datacolor SpyderCheckr 48 before 2018",
.author = "Aurélien PIERRE",
.date = "dec, 9 2016",
.manufacturer = "DataColor",
.type = COLOR_CHECKER_SPYDER_48,
.ratio = 2.f / 3.f,
.radius = 0.035,
.patches = 48,
.size = { 8, 6 },
.middle_grey = 24,
.white = 21,
.black = 29,

Commit

No response

Where did you obtain darktable from?

self compiled

darktable version

5.4.1

What OS are you using?

Linux

What is the version of your OS?

Kubuntu 22.04

Describe your system

Don't know impact on calculated profile.

Are you using OpenCL GPU in darktable?

Yes

If yes, what is the GPU card and driver?

No response

Please provide additional context if applicable. You can attach files too, but might need to rename to .txt or .zip

No response

Metadata

Metadata

Assignees

No one assigned

    Labels

    bug: pendingsomeone needs to start working on thatdifficulty: trivialsome changes in a couple of functionspriority: highcore features are broken and not usable at all, software crashes

    Type

    No type

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions