From 28af1d1f76c042cfaa973a4a1484de49fe2416bc Mon Sep 17 00:00:00 2001 From: darrenge Date: Wed, 16 Oct 2024 13:02:04 -0700 Subject: [PATCH] Cleaned up old comments and reduced threshold range to 130% --- .github/workflows/ci-bdnbenchmark.yml | 14 +++----------- 1 file changed, 3 insertions(+), 11 deletions(-) diff --git a/.github/workflows/ci-bdnbenchmark.yml b/.github/workflows/ci-bdnbenchmark.yml index fb941195f8..cbee4641d4 100644 --- a/.github/workflows/ci-bdnbenchmark.yml +++ b/.github/workflows/ci-bdnbenchmark.yml @@ -71,29 +71,21 @@ jobs: ./test/BDNPerfTests/errorlog if: ${{ always() }} -# Probably do not need since not using cache - # Download previous benchmark result from cache (if exists) -# - name: Download previous benchmark data -# uses: actions/cache@v4 -# with: -# path: ./cache -# key: ${{ runner.os }}-benchmark - - # Run `github-action-benchmark` action + # Run `github-action-benchmark` action to get Commit Comment - name: Store benchmark result for commit comment uses: benchmark-action/github-action-benchmark@v1 with: tool: 'benchmarkdotnet' output-file-path: ./test/BDNPerfTests/BenchmarkDotNet.Artifacts/results/BDN.benchmark.${{ matrix.test }}-report-full-compressed.json github-token: ${{ secrets.GITHUB_TOKEN }} - alert-threshold: '140%' + alert-threshold: '130%' comment-on-alert: true fail-on-alert: true alert-comment-cc-users: '@darrenge' summary-always: false auto-push: true - # Run `github-action-benchmark` action + # Run `github-action-benchmark` action for the Continuous Benchmarking Charts - name: Store benchmark result for charts uses: benchmark-action/github-action-benchmark@v1 with: