diff --git a/.github/workflows/ci-bdnbenchmark.yml b/.github/workflows/ci-bdnbenchmark.yml index 14daa5bd8e..40f68938a6 100644 --- a/.github/workflows/ci-bdnbenchmark.yml +++ b/.github/workflows/ci-bdnbenchmark.yml @@ -79,27 +79,27 @@ jobs: key: ${{ runner.os }}-benchmark # Run `github-action-benchmark` action - - name: Store benchmark result for commit comment + - name: Store benchmark result for charts uses: benchmark-action/github-action-benchmark@v1 with: + name: BDNBenchmark - ${{matrix.test}} (os ${{matrix.os}}, framework ${{matrix.framework}}, configuration ${{matrix.configuration}}) tool: 'benchmarkdotnet' output-file-path: ./test/BDNPerfTests/BenchmarkDotNet.Artifacts/results/BDN.benchmark.${{ matrix.test }}-report-full-compressed.json github-token: ${{ secrets.GITHUB_TOKEN }} - alert-threshold: '110%' - external-data-json-path: ./cache/benchmark-data.json - comment-on-alert: true - fail-on-alert: true - alert-comment-cc-users: '@darrenge' - summary-always: false - auto-push: false # needs to be false if using external-data-json-path + summary-always: true + auto-push: true # Run `github-action-benchmark` action - - name: Store benchmark result for charts + - name: Store benchmark result for commit comment uses: benchmark-action/github-action-benchmark@v1 with: - name: BDNBenchmark - ${{matrix.test}} (os ${{matrix.os}}, framework ${{matrix.framework}}, configuration ${{matrix.configuration}}) tool: 'benchmarkdotnet' output-file-path: ./test/BDNPerfTests/BenchmarkDotNet.Artifacts/results/BDN.benchmark.${{ matrix.test }}-report-full-compressed.json github-token: ${{ secrets.GITHUB_TOKEN }} - summary-always: true - auto-push: true + alert-threshold: '115%' + external-data-json-path: ./cache/benchmark-data.json + comment-on-alert: true + fail-on-alert: true + alert-comment-cc-users: '@darrenge' + summary-always: false + auto-push: false # needs to be false if using external-data-json-path diff --git a/test/BDNPerfTests/run_bdnperftest.ps1 b/test/BDNPerfTests/run_bdnperftest.ps1 index 7b636ce7cd..ca7255589a 100644 --- a/test/BDNPerfTests/run_bdnperftest.ps1 +++ b/test/BDNPerfTests/run_bdnperftest.ps1 @@ -42,7 +42,7 @@ function AnalyzeResult { # Check if the actual value is within the bounds if ($dblfoundResultValue -ge $LowerBound -and $dblfoundResultValue -le $UpperBound) { - Write-Host "** ** PASS! ** Test Value result ($dblfoundResultValue) is in the acceptable range +/-$acceptablePercentRange% ($LowerBound -> $UpperBound) of expected value: $expectedResultValue " + Write-Host "** ** PASS! ** Test Value result ($dblfoundResultValue) is in the acceptable range +/-$acceptablePercentRange% ($LowerBound -> $UpperBound) of expected value: $expectedResultValue " Write-Host "** " return $true # the values are close enough }