From 70183df81bda5d5c9596a82ebfc3b7f42aeeee79 Mon Sep 17 00:00:00 2001 From: darrenge Date: Thu, 17 Oct 2024 15:54:46 -0700 Subject: [PATCH] Cleaned up config files, set allocated for those to 10% and set the Mean threshhold back to 140% --- .github/workflows/ci-bdnbenchmark.yml | 2 +- .../ConfigFiles/CI_BDN_Config_Cluster.RespClusterBench.json | 1 + .../CI_BDN_Config_Cluster.RespClusterMigrateBench.json | 2 ++ .../ConfigFiles/CI_BDN_Config_Resp.RespLuaStress.json | 1 - .../ConfigFiles/CI_BDN_Config_Resp.RespParseStress.json | 1 - .../ConfigFiles/CI_BDN_Config_Resp.RespTsavoriteStress.json | 2 ++ 6 files changed, 6 insertions(+), 3 deletions(-) diff --git a/.github/workflows/ci-bdnbenchmark.yml b/.github/workflows/ci-bdnbenchmark.yml index a3d4f23878..e96990898c 100644 --- a/.github/workflows/ci-bdnbenchmark.yml +++ b/.github/workflows/ci-bdnbenchmark.yml @@ -78,7 +78,7 @@ jobs: tool: 'benchmarkdotnet' output-file-path: ./test/BDNPerfTests/BenchmarkDotNet.Artifacts/results/BDN.benchmark.${{ matrix.test }}-report-full-compressed.json github-token: ${{ secrets.GITHUB_TOKEN }} - alert-threshold: '110%' + alert-threshold: '140%' comment-on-alert: true fail-on-alert: true alert-comment-cc-users: '@darrenge' diff --git a/test/BDNPerfTests/ConfigFiles/CI_BDN_Config_Cluster.RespClusterBench.json b/test/BDNPerfTests/ConfigFiles/CI_BDN_Config_Cluster.RespClusterBench.json index 55cb9d5b59..b6c38afb3b 100644 --- a/test/BDNPerfTests/ConfigFiles/CI_BDN_Config_Cluster.RespClusterBench.json +++ b/test/BDNPerfTests/ConfigFiles/CI_BDN_Config_Cluster.RespClusterBench.json @@ -3,6 +3,7 @@ "framework": "net8.0", "filter": "*RespClusterBench*", + "acceptableAllocatedRange": 10, "acceptableError": ".1", "acceptableStdDev": ".1" } diff --git a/test/BDNPerfTests/ConfigFiles/CI_BDN_Config_Cluster.RespClusterMigrateBench.json b/test/BDNPerfTests/ConfigFiles/CI_BDN_Config_Cluster.RespClusterMigrateBench.json index ed0baa87c9..90c9408bd1 100644 --- a/test/BDNPerfTests/ConfigFiles/CI_BDN_Config_Cluster.RespClusterMigrateBench.json +++ b/test/BDNPerfTests/ConfigFiles/CI_BDN_Config_Cluster.RespClusterMigrateBench.json @@ -2,6 +2,8 @@ "configuration": "Release", "framework": "net8.0", "filter": "*RespClusterMigrateBench*", + + "acceptableAllocatedRange": 10, "acceptableError": ".1", "acceptableStdDev": ".1" } diff --git a/test/BDNPerfTests/ConfigFiles/CI_BDN_Config_Resp.RespLuaStress.json b/test/BDNPerfTests/ConfigFiles/CI_BDN_Config_Resp.RespLuaStress.json index fd00b7150a..ca67c58cca 100644 --- a/test/BDNPerfTests/ConfigFiles/CI_BDN_Config_Resp.RespLuaStress.json +++ b/test/BDNPerfTests/ConfigFiles/CI_BDN_Config_Resp.RespLuaStress.json @@ -13,7 +13,6 @@ "expectedBasicLuaStress3AllocatedValue_win": 328, "expectedBasicLuaStress4AllocatedValue_win": 832, - "acceptableMeanRange": 15, "acceptableAllocatedRange": 10, "acceptableError": ".1", "acceptableStdDev": ".1" diff --git a/test/BDNPerfTests/ConfigFiles/CI_BDN_Config_Resp.RespParseStress.json b/test/BDNPerfTests/ConfigFiles/CI_BDN_Config_Resp.RespParseStress.json index 5a8016512e..c32c8979c0 100644 --- a/test/BDNPerfTests/ConfigFiles/CI_BDN_Config_Resp.RespParseStress.json +++ b/test/BDNPerfTests/ConfigFiles/CI_BDN_Config_Resp.RespParseStress.json @@ -15,7 +15,6 @@ "expectedHSetDelAllocatedValue_win": 55297, "expectedMyDictSetGetAllocatedValue_win": 30720, - "acceptableMeanRange": 15, "acceptableAllocatedRange": 10, "acceptableError": ".1", "acceptableStdDev": ".1" diff --git a/test/BDNPerfTests/ConfigFiles/CI_BDN_Config_Resp.RespTsavoriteStress.json b/test/BDNPerfTests/ConfigFiles/CI_BDN_Config_Resp.RespTsavoriteStress.json index 23b336ad7f..954ecd6e61 100644 --- a/test/BDNPerfTests/ConfigFiles/CI_BDN_Config_Resp.RespTsavoriteStress.json +++ b/test/BDNPerfTests/ConfigFiles/CI_BDN_Config_Resp.RespTsavoriteStress.json @@ -2,6 +2,8 @@ "configuration": "Release", "framework": "net8.0", "filter": "*RespTsavoriteStress*", + + "acceptableAllocatedRange": 10, "acceptableError": ".1", "acceptableStdDev": ".1" }