From 2e375a283885afd2d959afc6ae7a286ef7e9e208 Mon Sep 17 00:00:00 2001 From: Kevin Moore Date: Mon, 18 Dec 2023 12:20:02 -0800 Subject: [PATCH] Enable and fix new lints --- CHANGELOG.md | 2 +- analysis_options.yaml | 5 ----- pubspec.yaml | 6 +++--- test/hex_test.dart | 8 ++++---- test/percent_test.dart | 10 +++++----- 5 files changed, 13 insertions(+), 18 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 925b1d6..00b795d 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,4 +1,4 @@ -## 3.1.2-dev +## 3.1.2-wip - Require Dart 3.0 - Add chunked decoding support (`startChunkedConversion`) for `CodePage` diff --git a/analysis_options.yaml b/analysis_options.yaml index 6c58fa8..2098238 100644 --- a/analysis_options.yaml +++ b/analysis_options.yaml @@ -13,17 +13,12 @@ linter: - avoid_unused_constructor_parameters - avoid_void_async - cancel_subscriptions - - comment_references - literal_only_boolean_expressions - missing_whitespace_between_adjacent_strings - no_adjacent_strings_in_list - no_runtimeType_toString - package_api_docs - - prefer_const_constructors - prefer_const_declarations - prefer_expression_function_bodies - - prefer_relative_imports - - test_types_in_equals - unnecessary_await_in_return - use_string_buffers - - use_super_parameters diff --git a/pubspec.yaml b/pubspec.yaml index 77a7edb..59d6f9d 100644 --- a/pubspec.yaml +++ b/pubspec.yaml @@ -1,17 +1,17 @@ name: convert -version: 3.1.2-dev +version: 3.1.2-wip description: >- Utilities for converting between data representations. Provides a number of Sink, Codec, Decoder, and Encoder types. repository: https://github.com/dart-lang/convert environment: - sdk: '^3.0.0' + sdk: ^3.0.0 dependencies: typed_data: ^1.3.0 dev_dependencies: benchmark_harness: ^2.2.0 - dart_flutter_team_lints: ^1.0.0 + dart_flutter_team_lints: ^2.0.0 test: ^1.17.0 diff --git a/test/hex_test.dart b/test/hex_test.dart index 7632cb1..abd940f 100644 --- a/test/hex_test.dart +++ b/test/hex_test.dart @@ -147,16 +147,16 @@ void main() { expect(results, isEmpty); sink.add('0'); - expect(results, equals([[]])); + expect(results, equals([[]])); sink.add(''); - expect(results, equals([[]])); + expect(results, equals([[]])); sink.add('0'); expect( results, equals([ - [], + [], [0x00] ])); @@ -164,7 +164,7 @@ void main() { expect( results, equals([ - [], + [], [0x00] ])); }); diff --git a/test/percent_test.dart b/test/percent_test.dart index cc74a69..4e0f605 100644 --- a/test/percent_test.dart +++ b/test/percent_test.dart @@ -154,22 +154,22 @@ void main() { expect(results, isEmpty); sink.add('%'); - expect(results, equals([[]])); + expect(results, equals([[]])); sink.add(''); - expect(results, equals([[]])); + expect(results, equals([[]])); sink.add('2'); - expect(results, equals([[]])); + expect(results, equals([[]])); sink.add(''); - expect(results, equals([[]])); + expect(results, equals([[]])); sink.add('0'); expect( results, equals([ - [], + [], [0x20] ])); });