[dart2js] Remove memberContext from getConstantValue.

Change-Id: I3ed4343c7cd2880414a8e99361d8017ca9f756a8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/372160
Commit-Queue: Mayank Patke <fishythefish@google.com>
Reviewed-by: Nate Biggs <natebiggs@google.com>

Author: fishythefish

pkg/compiler/lib/src/js_model/closure.dart

@@ -1260,15 +1260,6 @@ class ClosureFunctionData extends ClosureMemberData
     sink.end(tag);
   }
 
-  @override
-  late final ir.Member memberContext = (() {
-    ir.TreeNode parent = functionNode;
-    while (parent is! ir.Member) {
-      parent = parent.parent!;
-    }
-    return parent;
-  })();
-
   @override
   FunctionType getFunctionType(IrToElementMap elementMap) {
     return functionType;

pkg/compiler/lib/src/js_model/element_map.dart

@@ -94,11 +94,7 @@ abstract class JsToElementMap {
       ir.StaticInvocation node);
 
   /// Computes the [ConstantValue] for the constant [expression].
-  // TODO(johnniwinther,sigmund): Remove the need for [memberContext]. This is
-  //  only needed because effectively constant expressions are not replaced by
-  //  constant expressions during resolution.
-  ConstantValue? getConstantValue(
-      ir.Member? memberContext, ir.Expression? expression,
+  ConstantValue? getConstantValue(ir.Expression? expression,
       {bool requireConstant = true, bool implicitNull = false});
 
   /// Returns the [ConstantValue] for the sentinel used to indicate that a

pkg/compiler/lib/src/js_model/element_map_impl.dart

@@ -1306,7 +1306,7 @@ class JsKernelToElementMap implements JsToElementMap, IrToElementMap {
   }
 
   @override
-  ConstantValue? getConstantValue(ir.Member? memberContext, ir.Expression? node,
+  ConstantValue? getConstantValue(ir.Expression? node,
       {bool requireConstant = true, bool implicitNull = false}) {
     if (node == null) {
       if (!implicitNull) {

pkg/compiler/lib/src/js_model/env.dart

@@ -685,10 +685,6 @@ mixin FunctionDataTypeVariablesMixin implements FunctionData {
 mixin FunctionDataForEachParameterMixin implements FunctionData {
   ir.FunctionNode get functionNode;
 
-  // TODO(johnniwinther,sigmund): Remove this when it's no longer needed for
-  //  `getConstantValue` in [forEachParameter].
-  ir.Member get memberContext;
-
   @override
   void forEachParameter(
       JsToElementMap elementMap,
@@ -708,8 +704,7 @@ mixin FunctionDataForEachParameterMixin implements FunctionData {
         }
       } else if (isOptional) {
         if (parameter.initializer != null) {
-          defaultValue = elementMap.getConstantValue(
-              memberContext, parameter.initializer!);
+          defaultValue = elementMap.getConstantValue(parameter.initializer!);
         } else {
           defaultValue = NullConstantValue();
         }
@@ -772,9 +767,6 @@ class FunctionDataImpl extends JMemberDataImpl
     sink.end(tag);
   }
 
-  @override
-  ir.Member get memberContext => node;
-
   @override
   FunctionType getFunctionType(covariant JsKernelToElementMap elementMap) {
     return _type ??= elementMap.getFunctionType(functionNode);

pkg/compiler/lib/src/kernel/env.dart

@@ -492,8 +492,7 @@ class KFunctionData extends KMemberData {
       ConstantValue? defaultValue;
       if (isOptional) {
         if (parameter.initializer != null) {
-          defaultValue =
-              elementMap.getConstantValue(node, parameter.initializer);
+          defaultValue = elementMap.getConstantValue(parameter.initializer);
         } else {
           defaultValue = NullConstantValue();
         }