Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support loading DartPad sources from site vs Gist #1919

Closed
chalin opened this issue Sep 19, 2019 · 2 comments · Fixed by #2124
Closed

Support loading DartPad sources from site vs Gist #1919

chalin opened this issue Sep 19, 2019 · 2 comments · Fixed by #2124
Labels
e2-days Can complete in < 5 days of normal, not dedicated, work infra.structure Relates to the tools that create dart.dev p2-medium Necessary but not urgent concern. Resolve when possible.

Comments

@chalin
Copy link
Contributor

chalin commented Sep 19, 2019

The dartpad_picker illustrates how Dartpad sources can be loaded from somewhere other than a Gist. The tool is currently used to build a dropdown list that is shown on the homepage, but the functionality to load Dartpad sources could be factored out and reused elsewhere on the site.

Such an approach would address this issue that we opened over dartpad: dart-lang/dart-pad#788 Load content from any GitHub repo path.

Related: dart-lang/dart-pad#1096 Load exercises from a repo in addition to gists. In particular this comment: dart-lang/dart-pad#1096 (comment).
@chalin chalin added infra.structure Relates to the tools that create dart.dev e2-days Can complete in < 5 days of normal, not dedicated, work labels Sep 19, 2019
@chalin chalin changed the title Load Dartpad sources from site vs Gist Support loading Dartpad sources from site vs Gist Sep 19, 2019
@chalin chalin mentioned this issue Sep 19, 2019
Merged
@kwalrath kwalrath added the p2-medium Necessary but not urgent concern. Resolve when possible. label Sep 21, 2019
@chalin chalin changed the title Support loading Dartpad sources from site vs Gist Support loading DartPad sources from site vs Gist Sep 24, 2019
@RedBrogdon
Copy link
Collaborator

I've been working on this for a bit, and should have a PR to allow for loading from a repo ready for review in the next few days.

@chalin
Copy link
Contributor Author

chalin commented Oct 16, 2019

As I mentioned out-of-band, the GitHub rate limit (as was mentioned in this comment), might be another reason to explore the solution proposed here.

@chalin chalin mentioned this issue Oct 25, 2019
Closed
19 tasks
This was referenced Nov 14, 2019
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
e2-days Can complete in < 5 days of normal, not dedicated, work infra.structure Relates to the tools that create dart.dev p2-medium Necessary but not urgent concern. Resolve when possible.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Ensure Try-Dart example sources are analyzed and tested dart-lang/site-www
3 participants
@RedBrogdon @kwalrath @chalin