-
Notifications
You must be signed in to change notification settings - Fork 700
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Homepage Try-Dart example code issues #2126
Comments
@johnpryan what do you say? |
Do we need the |
We can certainly fix the examples, if you feel that the fixes proposed above are reasonable. To give you a bit of context: All of the site's example code is analyzed under the pedantic analyzer options. Elsewhere, @legalcodes and @kwalrath gave a thumbs up agreeing that:
If you agree too, then we should update the code, including removing the (Btw, in case you are wondering, |
That makes sense. I left some more specific comments here: #2124 (review) |
I think these issues are fixed by #2124 now. |
Consider making code changes shown in red to avoid the named analyzer issues:
Also, quite a few of the example files have
ignore: type_annotate_public_apis
which we might want to address.Followup to #2124 (comment). cc @mit-mit
The text was updated successfully, but these errors were encountered: