Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Homepage Try-Dart example code issues #2126

Closed
chalin opened this issue Nov 21, 2019 · 5 comments
Closed

Homepage Try-Dart example code issues #2126

chalin opened this issue Nov 21, 2019 · 5 comments
Assignees
Labels
fix.examples Adds or changes example

Comments

@chalin
Copy link
Contributor

chalin commented Nov 21, 2019

Consider making code changes shown in red to avoid the named analyzer issues:

Also, quite a few of the example files have ignore: type_annotate_public_apis which we might want to address.

Followup to #2124 (comment). cc @mit-mit

@chalin chalin added the fix.examples Adds or changes example label Nov 21, 2019
@kwalrath kwalrath added the act.wait-for-customer Needs response from customer label Nov 21, 2019
@kwalrath
Copy link
Contributor

@johnpryan what do you say?

@johnpryan
Copy link
Contributor

Do we need the ignore: statements or can we fix the samples?

@chalin
Copy link
Contributor Author

chalin commented Nov 23, 2019

We can certainly fix the examples, if you feel that the fixes proposed above are reasonable.

To give you a bit of context: All of the site's example code is analyzed under the pedantic analyzer options. Elsewhere, @legalcodes and @kwalrath gave a thumbs up agreeing that:

... pretty much all example code should be free of analyzer issues when configured with the pedantic options. -- From the short thread starting at #2128 (comment).

If you agree too, then we should update the code, including removing the ignore: type_annotate_public_apis directives and adding the necessary types.

(Btw, in case you are wondering, ignore directives in the example code don't show up in the published code because I've configured the code-excerpter to strip them out.)

@johnpryan
Copy link
Contributor

That makes sense. I left some more specific comments here: #2124 (review)

@chalin chalin removed the act.wait-for-customer Needs response from customer label Nov 25, 2019
@chalin chalin mentioned this issue Nov 25, 2019
19 tasks
@johnpryan
Copy link
Contributor

I think these issues are fixed by #2124 now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix.examples Adds or changes example
Projects
None yet
Development

No branches or pull requests

3 participants