Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update isolates.md #6052

Merged
merged 5 commits into from
Aug 24, 2024
Merged

Update isolates.md #6052

merged 5 commits into from
Aug 24, 2024

Conversation

Coloud1
Copy link
Contributor

@Coloud1 Coloud1 commented Aug 20, 2024

Updated the link to Concurrency and isolates from flutter.dev to docs.flutter.dev. Updated link leading to dart api documentation about Isolate.run

Fixes #6051


  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.
  • This PR doesn't contain automatically generated corrections or text (Grammarly, LLMs, and similar).
  • This PR follows the Google Developer Documentation Style Guidelines — for example, it doesn't use i.e. or e.g., and it avoids I and we (first person).
  • This PR uses semantic line breaks of 80 characters or fewer.
Contribution guidelines:
  • See our contributor guide for general expectations for PRs.
  • Larger or significant changes should be discussed in an issue before creating a PR.
  • Code changes should generally follow the Dart style guide and use dart format.
  • Updates to code excerpts indicated by <?code-excerpt need to be updated in their source .dart file as well.

Updated the link to Concurrency and isolates from flutter.dev to docs.flutter.dev
Changed link to Api documentation about Isolate.run
Removed /dev/ path
Added site.dart-api to /dart-isolate/Isolate/run.html
@sfshaza2 sfshaza2 closed this Aug 22, 2024
Copy link
Collaborator

@sfshaza2 sfshaza2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@sfshaza2 sfshaza2 reopened this Aug 22, 2024
@sfshaza2
Copy link
Collaborator

Wow, that "/" comment was a typo. I never knew that it could close a PR!

@sfshaza2
Copy link
Collaborator

/gcbrun

@dart-github-bot
Copy link
Collaborator

Visit the preview URL for this PR (updated for commit f08800c):

https://dart-dev--pr6052-patch-3-mnappl7f.web.app

@Coloud1
Copy link
Contributor Author

Coloud1 commented Aug 22, 2024

Wow, that "/" comment was a typo. I never knew that it could close a PR!

But now we both know about it (:

Copy link
Member

@parlough parlough left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching and fixing these links!

Copy link
Member

@parlough parlough left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching and fixing these links!

@parlough parlough merged commit 7007b4f into dart-lang:main Aug 24, 2024
10 checks passed
@Coloud1 Coloud1 deleted the patch-3 branch August 24, 2024 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect redirect on the page about Isolate
4 participants