Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add rethrow; #6056

Closed
wants to merge 1 commit into from
Closed

add rethrow; #6056

wants to merge 1 commit into from

Conversation

AbdeMohlbi
Copy link
Contributor

@AbdeMohlbi AbdeMohlbi commented Aug 22, 2024

Fixes #6047


  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.
  • This PR doesn't contain automatically generated corrections or text (Grammarly, LLMs, and similar).
  • This PR follows the Google Developer Documentation Style Guidelines — for example, it doesn't use i.e. or e.g., and it avoids I and we (first person).
  • This PR uses semantic line breaks of 80 characters or fewer.
Contribution guidelines:
  • See our contributor guide for general expectations for PRs.
  • Larger or significant changes should be discussed in an issue before creating a PR.
  • Code changes should generally follow the Dart style guide and use dart format.
  • Updates to code excerpts indicated by <?code-excerpt need to be updated in their source .dart file as well.

@AbdeMohlbi
Copy link
Contributor Author

@nate-thegrate

@sfshaza2
Copy link
Collaborator

/gcbrun

@sfshaza2
Copy link
Collaborator

@domesticmouse, can you confirm this code change?

@dart-github-bot
Copy link
Collaborator

Visit the preview URL for this PR (updated for commit 267c61b):

https://dart-dev--pr6056-main-f4j5qp1v.web.app

Copy link

@nate-thegrate nate-thegrate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful ❤️

@nate-thegrate
Copy link

@AbdeMohlbi it looks like being a member of flutter-hackers unfortunately doesn't give me commit access here, so you'll have to wait for someone else to review.


For @domesticmouse and/or other reviewer(s): previous discussion for context

@AbdeMohlbi
Copy link
Contributor Author

AbdeMohlbi commented Aug 22, 2024

@AbdeMohlbi it looks like being a member of flutter-hackers unfortunately doesn't give me commit access here, so you'll have to wait for someone else to review.


For @domesticmouse and/or other reviewer(s): previous discussion for context

No problem man just wanted to asure i'm on the right path

@AbdeMohlbi AbdeMohlbi closed this Aug 29, 2024
@nate-thegrate
Copy link

I'm curious… why did this get closed? I think it's a good change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

issue in usage of wait on a record of futures in docs
4 participants