Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify implementation of homepage layout and styles #6350

Merged
merged 9 commits into from
Jan 23, 2025
Merged

Simplify implementation of homepage layout and styles #6350

merged 9 commits into from
Jan 23, 2025

Conversation

parlough
Copy link
Member

@parlough parlough commented Jan 23, 2025 •
edited
Loading

  • Removes reliance on bootstrap classes for layout and responsiveness.
  • Stops using bootstrap-provided mixins and other utilities.
  • Remove some unnecessary div nesting.
  • Rely on same elements for narrow and wide layouts so that it's not required to update two locations.
  • Adds a missing missing aria attributes where necessary to improve accessibility.
  • Other general cleanup.

Contributes to #4164
Contributes to #5251

@dart-github-bot
Copy link
Collaborator

dart-github-bot commented Jan 23, 2025 •
edited
Loading

Visit the preview URL for this PR (updated for commit 24352a4):

https://dart-dev--pr6350-feat-dash-homepage-simplify-9ii55b1m.web.app

MaryaBelanger
MaryaBelanger approved these changes Jan 23, 2025
View reviewed changes
Copy link
Contributor

@MaryaBelanger MaryaBelanger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@parlough parlough merged commit 41dfddc into main Jan 23, 2025
9 of 10 checks passed
@parlough parlough deleted the feat/dash-homepage-simplify branch January 23, 2025 18:55
@parlough parlough mentioned this pull request Jan 24, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MaryaBelanger MaryaBelanger MaryaBelanger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@parlough @dart-github-bot @MaryaBelanger