fix: remove extra leading size byte when using pubKeyHash to recreate script on the sighashTx

Author: coolaj86

dashtx.js

@@ -1063,7 +1063,7 @@ var DashTx = ("object" === typeof module && exports) || {};
             `signable input must have either 'pubKeyHash' or 'script'`,
           );
         }
-        lockScript = `${PKH_SCRIPT_SIZE}${OP_DUP}${OP_HASH160}${PKH_SIZE}${input.pubKeyHash}${OP_EQUALVERIFY}${OP_CHECKSIG}`;
+        lockScript = `${OP_DUP}${OP_HASH160}${PKH_SIZE}${input.pubKeyHash}${OP_EQUALVERIFY}${OP_CHECKSIG}`;
       }
       return {
         txId: input.txId,
@@ -1259,8 +1259,8 @@ var DashTx = ("object" === typeof module && exports) || {};
       }
       assertHex(output.pubKeyHash, `output[${i}].pubKeyHash`);
 
-      //let lockScript = `${PKH_SCRIPT_SIZE}${OP_DUP}${OP_HASH160}${PKH_SIZE}${output.pubKeyHash}${OP_EQUALVERIFY}${OP_CHECKSIG}`;
       outputHex.push(PKH_SCRIPT_SIZE);
+      //let lockScript = `${OP_DUP}${OP_HASH160}${PKH_SIZE}${output.pubKeyHash}${OP_EQUALVERIFY}${OP_CHECKSIG}`;
       outputHex.push(`${OP_DUP}${OP_HASH160}`);
       outputHex.push(PKH_SIZE);
       outputHex.push(output.pubKeyHash);
@@ -1330,8 +1330,8 @@ var DashTx = ("object" === typeof module && exports) || {};
 
     let lockScriptSizeHex = TxUtils.toVarInt(lockScriptSize);
 
-    //let lockScript = `${lockScriptSizeHex}${opReturn}${memoSizeHex}${memoHex}`;
     outputHex.push(lockScriptSizeHex);
+    //let lockScript = `${opReturn}${memoSizeHex}${memoHex}`;
     outputHex.push(opReturn);
     outputHex.push(memoSizeHex);
     outputHex.push(memoHex);

tests/memo.js

@@ -99,7 +99,7 @@ Zora.test("can create memo tx", async function (t) {
   let txInfoSigned = await dashTx.hashAndSignAll(txInfo, keys);
 
   let rawtx =
-    "03000000017777777777777777777777777777777777777777777777777777777777777777000000006a4730440220404c24dd8fff16b226c4795093b49e1060039c687120a9aaeca65cf321c593e00220180b160b3b2e937f9f5b9a8658a55c7511926b4631c421813c659e4f22b29140012103f808bdec4293bf12441ec9a9e61bc3b264c78fcc5ad499ce5f0799f2874e6856ffffffff0200000000000000000e6a0c48656c6c6f2c204461736821484d0000000000001976a91482754a9c935fbfcdda5995a32006a68a8156ee2b88ac00000000";
+    "03000000017777777777777777777777777777777777777777777777777777777777777777000000006b483045022100888db2ea9388e2c29d2480fd3374250cb2242a7dfa0e4bc6d82ac01b58f99dfb02200fe878c74f58eebf234f31a43a17bc6ea1535de6f7f2329ac007107888a39199012103f808bdec4293bf12441ec9a9e61bc3b264c78fcc5ad499ce5f0799f2874e6856ffffffff0200000000000000000e6a0c48656c6c6f2c204461736821484d0000000000001976a91482754a9c935fbfcdda5995a32006a68a8156ee2b88ac00000000";
 
   t.equal(txInfoSigned.transaction, rawtx, "created transaction with memo");
 });
@@ -129,7 +129,7 @@ Zora.test("can create donation tx via memo", async function (t) {
   let txHex = txInfoSigned.transaction;
 
   let rawtx =
-    "03000000017777777777777777777777777777777777777777777777777777777777777777000000006b483045022100d2a13920c4002ee76df3cd3a0afcebb12e71871c63bb49ba379de6d709f488b60220627252f66903c3dfa69ba86a581c09342721a15d75e2a455a2dff09187e7668e012103f808bdec4293bf12441ec9a9e61bc3b264c78fcc5ad499ce5f0799f2874e6856ffffffff010000000000000000066a04f09fa7a700000000";
+    "03000000017777777777777777777777777777777777777777777777777777777777777777000000006a473044022031192f34981eee578bdd8a5347f6f2d78e466af0749865b785b260d9cd4202930220193cc65d5e430784f4a92dc6d2ae78ca382262379a465d254ecbc5134c20bded012103f808bdec4293bf12441ec9a9e61bc3b264c78fcc5ad499ce5f0799f2874e6856ffffffff010000000000000000066a04f09fa7a700000000";
 
   t.equal(txHex, rawtx, "created donation transaction via memo");
 });