Skip to content

Commit 252eef5

Browse files
msgilliganHashEngineering
authored andcommitted
Use JDK7+ Objects.hash() and equals() rather than the Guava variants.
The Guava variants are “deprecated” for JDK7+. (cherry picked from commit 686a10ccd2c6bd06a7c785e1c637b611a6b8c0d0) Signed-off-by: HashEngineering <hashengineeringsolutions@gmail.com>
1 parent ed21434 commit 252eef5

34 files changed

+90
-91
lines changed

core/src/main/java/org/bitcoinj/core/Address.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@
3030
import org.bitcoinj.script.Script.ScriptType;
3131
import org.bitcoinj.script.ScriptPattern;
3232

33-
import com.google.common.base.Objects;
33+
import java.util.Objects;
3434

3535
/**
3636
* <p>A Bitcoin address looks like 1MsScoe2fTJoq4ZPdQgqyhgWeoNamYPevy and is derived from an elliptic curve public key
@@ -284,7 +284,7 @@ public boolean equals(Object o) {
284284

285285
@Override
286286
public int hashCode() {
287-
return Objects.hashCode(super.hashCode(), p2sh);
287+
return Objects.hash(super.hashCode(), p2sh);
288288
}
289289

290290
@Override

core/src/main/java/org/bitcoinj/core/BloomFilter.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,14 +23,14 @@
2323
import org.bitcoinj.script.ScriptPattern;
2424

2525
import com.google.common.base.MoreObjects;
26-
import com.google.common.base.Objects;
2726
import com.google.common.collect.Lists;
2827

2928
import java.io.IOException;
3029
import java.io.OutputStream;
3130
import java.util.ArrayList;
3231
import java.util.Arrays;
3332
import java.util.List;
33+
import java.util.Objects;
3434

3535
import static com.google.common.base.Preconditions.checkArgument;
3636
import static java.lang.Math.*;
@@ -373,7 +373,7 @@ public synchronized boolean equals(Object o) {
373373

374374
@Override
375375
public synchronized int hashCode() {
376-
return Objects.hashCode(hashFuncs, nTweak, Arrays.hashCode(data));
376+
return Objects.hash(hashFuncs, nTweak, Arrays.hashCode(data));
377377
}
378378

379379
public final byte[] getData() {

core/src/main/java/org/bitcoinj/core/ECKey.java

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,6 @@
2525

2626
import com.google.common.annotations.VisibleForTesting;
2727
import com.google.common.base.MoreObjects;
28-
import com.google.common.base.Objects;
2928
import com.google.common.base.Preconditions;
3029
import com.google.common.primitives.UnsignedBytes;
3130
import org.bitcoin.NativeSecp256k1;
@@ -62,6 +61,7 @@
6261
import java.security.SignatureException;
6362
import java.util.Arrays;
6463
import java.util.Comparator;
64+
import java.util.Objects;
6565

6666
import static com.google.common.base.Preconditions.*;
6767

@@ -611,7 +611,7 @@ public boolean equals(Object o) {
611611

612612
@Override
613613
public int hashCode() {
614-
return Objects.hashCode(r, s);
614+
return Objects.hash(r, s);
615615
}
616616
}
617617

@@ -1340,11 +1340,11 @@ public boolean equals(Object o) {
13401340
if (this == o) return true;
13411341
if (o == null || !(o instanceof ECKey)) return false;
13421342
ECKey other = (ECKey) o;
1343-
return Objects.equal(this.priv, other.priv)
1344-
&& Objects.equal(this.pub, other.pub)
1345-
&& Objects.equal(this.creationTimeSeconds, other.creationTimeSeconds)
1346-
&& Objects.equal(this.keyCrypter, other.keyCrypter)
1347-
&& Objects.equal(this.encryptedPrivateKey, other.encryptedPrivateKey);
1343+
return Objects.equals(this.priv, other.priv)
1344+
&& Objects.equals(this.pub, other.pub)
1345+
&& Objects.equals(this.creationTimeSeconds, other.creationTimeSeconds)
1346+
&& Objects.equals(this.keyCrypter, other.keyCrypter)
1347+
&& Objects.equals(this.encryptedPrivateKey, other.encryptedPrivateKey);
13481348
}
13491349

13501350
@Override

core/src/main/java/org/bitcoinj/core/FilteredBlock.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,6 @@
1717

1818
package org.bitcoinj.core;
1919

20-
import com.google.common.base.Objects;
2120
import java.io.IOException;
2221
import java.io.OutputStream;
2322
import java.util.*;
@@ -136,7 +135,7 @@ public boolean equals(Object o) {
136135

137136
@Override
138137
public int hashCode() {
139-
return Objects.hashCode(associatedTransactions, header, merkleTree);
138+
return Objects.hash(associatedTransactions, header, merkleTree);
140139
}
141140

142141
@Override

core/src/main/java/org/bitcoinj/core/GetUTXOsMessage.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,12 +16,12 @@
1616

1717
package org.bitcoinj.core;
1818

19-
import com.google.common.base.Objects;
2019
import com.google.common.collect.ImmutableList;
2120

2221
import java.io.IOException;
2322
import java.io.OutputStream;
2423
import java.util.List;
24+
import java.util.Objects;
2525

2626
/**
2727
* <p>This command is supported only by <a href="http://github.com/bitcoinxt/bitcoinxt">Bitcoin XT</a> nodes, which
@@ -100,6 +100,6 @@ public boolean equals(Object o) {
100100

101101
@Override
102102
public int hashCode() {
103-
return Objects.hashCode(includeMempool, outPoints);
103+
return Objects.hash(includeMempool, outPoints);
104104
}
105105
}

core/src/main/java/org/bitcoinj/core/InventoryItem.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616

1717
package org.bitcoinj.core;
1818

19-
import com.google.common.base.Objects;
19+
import java.util.Objects;
2020

2121
public class InventoryItem {
2222

@@ -86,6 +86,6 @@ public boolean equals(Object o) {
8686

8787
@Override
8888
public int hashCode() {
89-
return Objects.hashCode(type, hash);
89+
return Objects.hash(type, hash);
9090
}
9191
}

core/src/main/java/org/bitcoinj/core/NetworkParameters.java

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,8 +17,10 @@
1717

1818
package org.bitcoinj.core;
1919

20+
import org.bitcoinj.core.Block;
21+
import org.bitcoinj.core.StoredBlock;
22+
import org.bitcoinj.core.VerificationException;
2023
import com.google.common.annotations.VisibleForTesting;
21-
import com.google.common.base.Objects;
2224
import org.bitcoinj.net.discovery.*;
2325
import org.bitcoinj.params.*;
2426
import org.bitcoinj.script.*;
@@ -298,7 +300,7 @@ public boolean equals(Object o) {
298300

299301
@Override
300302
public int hashCode() {
301-
return Objects.hashCode(getId());
303+
return Objects.hash(getId());
302304
}
303305

304306
/** Returns the network parameters for the given string ID or NULL if not recognized. */

core/src/main/java/org/bitcoinj/core/PartialMerkleTree.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,9 +23,9 @@
2323
import java.util.ArrayList;
2424
import java.util.Arrays;
2525
import java.util.List;
26+
import java.util.Objects;
2627

2728
import static org.bitcoinj.core.Utils.*;
28-
import com.google.common.base.Objects;
2929

3030
/**
3131
* <p>A data structure that contains proofs of block inclusion for one or more transactions, in an efficient manner.</p>
@@ -275,7 +275,7 @@ public boolean equals(Object o) {
275275

276276
@Override
277277
public int hashCode() {
278-
return Objects.hashCode(transactionCount, hashes, Arrays.hashCode(matchedChildBits));
278+
return Objects.hash(transactionCount, hashes, Arrays.hashCode(matchedChildBits));
279279
}
280280

281281
@Override

core/src/main/java/org/bitcoinj/core/Peer.java

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -16,9 +16,6 @@
1616

1717
package org.bitcoinj.core;
1818

19-
import com.google.common.base.Objects;
20-
import com.google.common.collect.Lists;
21-
2219
import org.bitcoinj.coinjoin.CoinJoinQueue;
2320
import org.bitcoinj.core.listeners.*;
2421
import org.bitcoinj.evolution.SimplifiedMasternodeListDiff;
@@ -42,10 +39,12 @@
4239
import org.bitcoinj.wallet.Wallet;
4340

4441
import com.google.common.base.Function;
42+
import com.google.common.base.Joiner;
4543
import com.google.common.base.MoreObjects;
4644
import com.google.common.base.Preconditions;
4745
import com.google.common.base.Strings;
4846
import com.google.common.base.Throwables;
47+
import com.google.common.collect.Lists;
4948
import com.google.common.util.concurrent.FutureCallback;
5049
import com.google.common.util.concurrent.Futures;
5150
import com.google.common.util.concurrent.ListenableFuture;
@@ -1764,7 +1763,7 @@ private void blockChainDownloadLocked(Sha256Hash toHash) {
17641763
StoredBlock chainHead = blockChain.getChainHead();
17651764
Sha256Hash chainHeadHash = chainHead.getHeader().getHash();
17661765
// Did we already make this request? If so, don't do it again.
1767-
if (Objects.equal(lastGetBlocksBegin, chainHeadHash) && Objects.equal(lastGetBlocksEnd, toHash)) {
1766+
if (Objects.equals(lastGetBlocksBegin, chainHeadHash) && Objects.equals(lastGetBlocksEnd, toHash)) {
17681767
log.info("blockChainDownloadLocked({}): ignoring duplicated request: {}", toHash, chainHeadHash);
17691768
for (Sha256Hash hash : pendingBlockDownloads)
17701769
log.info("Pending block download: {}", hash);
@@ -1841,7 +1840,7 @@ private void blockChainHeaderDownloadLocked(Sha256Hash toHash) {
18411840
StoredBlock chainHead = headerChain.getChainHead();
18421841
Sha256Hash chainHeadHash = chainHead.getHeader().getHash();
18431842
// Did we already make this request? If so, don't do it again.
1844-
if (Objects.equal(lastGetHeadersBegin, chainHeadHash) && Objects.equal(lastGetHeadersEnd, toHash)) {
1843+
if (Objects.equals(lastGetHeadersBegin, chainHeadHash) && Objects.equals(lastGetHeadersEnd, toHash)) {
18451844
log.info("blockChainDownloadLocked({}): ignoring duplicated request: {}", toHash, chainHeadHash);
18461845
for (Sha256Hash hash : pendingBlockDownloads)
18471846
log.info("Pending block download: {}", hash);

core/src/main/java/org/bitcoinj/core/PeerAddress.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,14 +17,14 @@
1717

1818
package org.bitcoinj.core;
1919

20-
import com.google.common.base.Objects;
2120

2221
import java.io.IOException;
2322
import java.io.OutputStream;
2423
import java.math.BigInteger;
2524
import java.net.InetAddress;
2625
import java.net.InetSocketAddress;
2726
import java.net.UnknownHostException;
27+
import java.util.Objects;
2828

2929
import static com.google.common.base.Preconditions.checkNotNull;
3030

@@ -209,7 +209,7 @@ public boolean equals(Object o) {
209209

210210
@Override
211211
public int hashCode() {
212-
return Objects.hashCode(addr, port, time, services);
212+
return Objects.hash(addr, port, time, services);
213213
}
214214

215215
public InetSocketAddress toSocketAddress() {

core/src/main/java/org/bitcoinj/core/PrefixedChecksummedBytes.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,8 +23,8 @@
2323
import java.io.Serializable;
2424
import java.lang.reflect.Field;
2525
import java.util.Arrays;
26+
import java.util.Objects;
2627

27-
import com.google.common.base.Objects;
2828
import com.google.common.primitives.UnsignedBytes;
2929
import static com.google.common.base.Preconditions.checkNotNull;
3030

@@ -59,7 +59,7 @@ public final NetworkParameters getParameters() {
5959

6060
@Override
6161
public int hashCode() {
62-
return Objects.hashCode(params, Arrays.hashCode(bytes));
62+
return Objects.hash(params, Arrays.hashCode(bytes));
6363
}
6464

6565
@Override

core/src/main/java/org/bitcoinj/core/RejectMessage.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,11 +17,11 @@
1717

1818
package org.bitcoinj.core;
1919

20-
import com.google.common.base.Objects;
2120
import java.io.IOException;
2221
import java.io.OutputStream;
2322
import java.nio.charset.StandardCharsets;
2423
import java.util.Locale;
24+
import java.util.Objects;
2525

2626
/**
2727
* <p>A message sent by nodes when a message we sent was rejected (ie a transaction had too little fee/was invalid/etc).</p>
@@ -164,6 +164,6 @@ public boolean equals(Object o) {
164164

165165
@Override
166166
public int hashCode() {
167-
return Objects.hashCode(message, code, reason, messageHash);
167+
return Objects.hash(message, code, reason, messageHash);
168168
}
169169
}

core/src/main/java/org/bitcoinj/core/StoredBlock.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,11 +18,11 @@
1818

1919
import org.bitcoinj.store.BlockStore;
2020
import org.bitcoinj.store.BlockStoreException;
21-
import com.google.common.base.Objects;
2221

2322
import java.math.BigInteger;
2423
import java.nio.ByteBuffer;
2524
import java.util.Locale;
25+
import java.util.Objects;
2626

2727
import static com.google.common.base.Preconditions.checkState;
2828

@@ -91,7 +91,7 @@ public boolean equals(Object o) {
9191

9292
@Override
9393
public int hashCode() {
94-
return Objects.hashCode(header, chainWork, height);
94+
return Objects.hash(header, chainWork, height);
9595
}
9696

9797
/**

core/src/main/java/org/bitcoinj/core/TransactionInput.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,14 +24,14 @@
2424
import org.bitcoinj.wallet.RedeemData;
2525

2626
import com.google.common.base.Joiner;
27-
import com.google.common.base.Objects;
2827

2928
import javax.annotation.Nullable;
3029
import java.io.IOException;
3130
import java.io.OutputStream;
3231
import java.lang.ref.WeakReference;
3332
import java.util.Arrays;
3433
import java.util.Map;
34+
import java.util.Objects;
3535

3636
import static com.google.common.base.Preconditions.checkElementIndex;
3737
import static com.google.common.base.Preconditions.checkNotNull;
@@ -505,7 +505,7 @@ public boolean equals(Object o) {
505505

506506
@Override
507507
public int hashCode() {
508-
return Objects.hashCode(sequence, outpoint, Arrays.hashCode(scriptBytes));
508+
return Objects.hash(sequence, outpoint, Arrays.hashCode(scriptBytes));
509509
}
510510

511511
/**

core/src/main/java/org/bitcoinj/core/TransactionOutPoint.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,12 +17,12 @@
1717

1818
package org.bitcoinj.core;
1919

20-
import com.google.common.base.Objects;
2120
import org.bitcoinj.script.*;
2221
import org.bitcoinj.wallet.*;
2322

2423
import javax.annotation.*;
2524
import java.io.*;
25+
import java.util.Objects;
2626

2727
import static com.google.common.base.Preconditions.*;
2828

@@ -223,6 +223,6 @@ public boolean equals(Object o) {
223223

224224
@Override
225225
public int hashCode() {
226-
return Objects.hashCode(getIndex(), getHash());
226+
return Objects.hash(getIndex(), getHash());
227227
}
228228
}

core/src/main/java/org/bitcoinj/core/TransactionOutput.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,6 @@
1717

1818
package org.bitcoinj.core;
1919

20-
import com.google.common.base.Objects;
2120
import org.bitcoinj.script.*;
2221
import org.bitcoinj.wallet.Wallet;
2322
import org.slf4j.*;
@@ -26,6 +25,7 @@
2625
import java.io.*;
2726
import java.util.Arrays;
2827
import java.util.List;
28+
import java.util.Objects;
2929

3030
import static com.google.common.base.Preconditions.*;
3131

@@ -408,6 +408,6 @@ public boolean equals(Object o) {
408408

409409
@Override
410410
public int hashCode() {
411-
return Objects.hashCode(value, parent, Arrays.hashCode(scriptBytes));
411+
return Objects.hash(value, parent, Arrays.hashCode(scriptBytes));
412412
}
413413
}

0 commit comments

Comments
 (0)