Skip to content

Conversation

@nadzhou
Copy link

@nadzhou nadzhou commented Dec 6, 2025

Closes #xxxx

  • Tests added / passed
  • Passes pre-commit run --all-files

Closes #2007 since other classes have been implemented. Happy to get feedback on this.

@nadzhou nadzhou requested a review from fjetter as a code owner December 6, 2025 02:07
@github-actions
Copy link
Contributor

github-actions bot commented Dec 6, 2025

Unit Test Results

See test report for an extended history of previous test failures. This is useful for diagnosing flaky tests.

    18 files   -      9      18 suites   - 9   4h 29m 17s ⏱️ - 5h 21m 7s
 3 165 tests  -    947   3 009 ✅  -    997    155 💤 +   51  1 ❌  - 1 
25 119 runs   - 26 397  23 970 ✅  - 25 360  1 145 💤  - 1 039  4 ❌ +2 

For more details on these failures, see this check.

Results for commit 34f5cb4. ± Comparison against base commit c26f4ca.

This pull request removes 952 and adds 5 tests. Note that renamed tests count towards both.
distributed.cli.tests.test_dask_worker ‑ test_listen_address_ipv6[tcp://[::1]:---nanny]
distributed.cli.tests.test_dask_worker ‑ test_listen_address_ipv6[tcp://[::1]:---no-nanny]
distributed.tests.test_config ‑ test_basic_config_does_not_override_default_logging
distributed.tests.test_config ‑ test_default_logging_does_not_override_basic_config
distributed.tests.test_config ‑ test_deprecations_on_env_variables
distributed.tests.test_config ‑ test_deprecations_on_set[args0-kwargs0]
distributed.tests.test_config ‑ test_deprecations_on_set[args1-kwargs1]
distributed.tests.test_config ‑ test_deprecations_on_set[args2-kwargs2]
distributed.tests.test_config ‑ test_deprecations_on_yaml[allowed-failures]
distributed.tests.test_config ‑ test_deprecations_on_yaml[allowed_failures]
…
distributed.cli.tests.test_dask_worker.test_listen_address_ipv6[tcp:..[ ‑ 1]:---nanny]
distributed.cli.tests.test_dask_worker.test_listen_address_ipv6[tcp:..[ ‑ 1]:---no-nanny]
distributed.tests.test_condition ‑ test_condition_acquire_release
distributed.tests.test_condition ‑ test_condition_context_manager
distributed.tests.test_condition ‑ test_condition_wait_notify
This pull request removes 18 skipped tests and adds 2 skipped tests. Note that renamed tests count towards both.
distributed.cli.tests.test_dask_worker ‑ test_listen_address_ipv6[tcp://[::1]:---nanny]
distributed.cli.tests.test_dask_worker ‑ test_listen_address_ipv6[tcp://[::1]:---no-nanny]
distributed.tests.test_config ‑ test_uvloop_event_loop
distributed.tests.test_counter ‑ test_digest[None-<lambda>]
distributed.tests.test_dask_collections ‑ test_sparse_arrays
distributed.tests.test_gc ‑ test_gc_diagnosis_rss_win
distributed.tests.test_metrics ‑ test_monotonic
distributed.tests.test_preload ‑ test_client_preload_click
distributed.tests.test_preload ‑ test_client_preload_text
distributed.tests.test_profile ‑ test_basic_low_level
…
distributed.cli.tests.test_dask_worker.test_listen_address_ipv6[tcp:..[ ‑ 1]:---nanny]
distributed.cli.tests.test_dask_worker.test_listen_address_ipv6[tcp:..[ ‑ 1]:---no-nanny]
This pull request skips 67 tests.
distributed.cli.tests.test_dask_scheduler ‑ test_dashboard_allowlist
distributed.cli.tests.test_dask_scheduler ‑ test_signal_handling[15]
distributed.cli.tests.test_dask_scheduler ‑ test_signal_handling[2]
distributed.cli.tests.test_dask_scheduler ‑ test_signal_handling[Signals.SIGINT]
distributed.cli.tests.test_dask_scheduler ‑ test_signal_handling[Signals.SIGTERM]
distributed.cli.tests.test_dask_scheduler ‑ test_single_executable_deprecated
distributed.cli.tests.test_dask_spec ‑ test_signal_handling_scheduler[15]
distributed.cli.tests.test_dask_spec ‑ test_signal_handling_scheduler[2]
distributed.cli.tests.test_dask_spec ‑ test_signal_handling_scheduler[Signals.SIGINT]
distributed.cli.tests.test_dask_spec ‑ test_signal_handling_scheduler[Signals.SIGTERM]
…

♻️ This comment has been updated with latest results.

@nadzhou nadzhou marked this pull request as draft December 6, 2025 06:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add Semaphore, Condition, Event

1 participant