Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(query): expand trim/ltrim/rtrim #16802

Merged
merged 2 commits into from
Nov 12, 2024
Merged

Conversation

TCeason
Copy link
Collaborator

@TCeason TCeason commented Nov 11, 2024

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

support

trim(<expr>, expr)
ltrim(<expr>, expr)
rtrim(<expr>, expr)

Fix : #16798

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@github-actions github-actions bot added the pr-feature this PR introduces a new feature to the codebase label Nov 11, 2024
@TCeason
Copy link
Collaborator Author

TCeason commented Nov 11, 2024

cc @soyeric128 doc need.

@TCeason
Copy link
Collaborator Author

TCeason commented Nov 11, 2024

cc @soyeric128 doc need.

Doc also need add "trim_leading", "trim_trailing", "trim_both",

@TCeason
Copy link
Collaborator Author

TCeason commented Nov 12, 2024

Please merge this pr. cc @BohuTANG

@sundy-li sundy-li added this pull request to the merge queue Nov 12, 2024
@BohuTANG BohuTANG removed this pull request from the merge queue due to a manual request Nov 12, 2024
@BohuTANG BohuTANG merged commit 6175b1a into databendlabs:main Nov 12, 2024
74 checks passed
@BohuTANG
Copy link
Member

@soyeric128 docs need update, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-feature this PR introduces a new feature to the codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Align TRIM Functions with Snowflake Syntax (TRIM, LTRIM, RTRIM)
3 participants