Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

databricks workspace import(_dir) should not automatically convert non-notebook .py files to notebooks #618

Open
cloudyday opened this issue Mar 20, 2023 · 2 comments

Comments

@cloudyday
Copy link

On the Databricks platform, it is possible to use regular python modules in Repos and Workspaces.
It is even suggested by Databricks to use typical software engineering best practises. Here and here.

However, when using the Databricks CLI for importing files, especially a directory, into a Workspace by using databricks workspace import_dir, all .py files get automatically transformed to notebooks. This makes them incompatible because they cannot be imported as modules anymore.

The import and import_dir commands should probably only convert .py files starting with # Databricks notebook source to notebooks.

@cloudyday cloudyday changed the title databricks workspace import(_dir) should not automatically convert .py files to notebooks databricks workspace import(_dir) should not automatically convert non-notebook .py files to notebooks Mar 20, 2023
@fferegrino
Copy link

Glad to know I am not the only one, I opened this issue before realising you had already raised this concern.

#630

@osuleiman
Copy link

I've just created a PR to help tackle this problem.

#643

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants