Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TECH DEBT]: Skip parsing notebook if present in the NotebookLinter._python_tree_cache #3552

Open
1 task done
JCZuurmond opened this issue Jan 20, 2025 · 0 comments
Open
1 task done
Labels
enhancement New feature or request internal this pull request won't appear in release notes migrate/code Abstract Syntax Trees and other dark magic needs-triage

Comments

@JCZuurmond
Copy link
Member

JCZuurmond commented Jan 20, 2025

Is there an existing issue for this?

  • I have searched the existing issues

Problem statement

Skip parsing notebook if present in the NotebookLinter._python_tree_cache. This means the notebook was already parsed because it was referred by another notebook using a RunCell

Proposed Solution

Use the cache to get the Python tree instead of parsing.

Notes:

  • this requires to extend the cache to contain failures too.
  • A notebook can be run from multiple parent notebooks. We need to handle that situation

Additional Context

No response

@JCZuurmond JCZuurmond added enhancement New feature or request internal this pull request won't appear in release notes migrate/code Abstract Syntax Trees and other dark magic needs-triage labels Jan 20, 2025
@JCZuurmond JCZuurmond added this to UCX Jan 20, 2025
@github-project-automation github-project-automation bot moved this to Todo in UCX Jan 20, 2025
JCZuurmond added a commit that referenced this issue Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request internal this pull request won't appear in release notes migrate/code Abstract Syntax Trees and other dark magic needs-triage
Projects
Status: Todo
Development

No branches or pull requests

1 participant