Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TECH DEBT]: Let python_ast.Tree.extend_globals accept a Tree as argument #3558

Open
1 task done
JCZuurmond opened this issue Jan 22, 2025 · 0 comments
Open
1 task done

[TECH DEBT]: Let python_ast.Tree.extend_globals accept a Tree as argument #3558

JCZuurmond opened this issue Jan 22, 2025 · 0 comments
Labels
enhancement New feature or request internal this pull request won't appear in release notes migrate/code Abstract Syntax Trees and other dark magic migrate/python Pull requests that update Python code needs-triage python Pull requests that update Python code

Comments

@JCZuurmond
Copy link
Member

Is there an existing issue for this?

  • I have searched the existing issues

Problem statement

Let python_ast.Tree.extend_globals accept a Tree as argument

Proposed Solution

Requires refactoring the inherited context to pass a tree instead of globals

Additional Context

No response
@JCZuurmond JCZuurmond added enhancement New feature or request internal this pull request won't appear in release notes migrate/code Abstract Syntax Trees and other dark magic migrate/python Pull requests that update Python code needs-triage python Pull requests that update Python code labels Jan 22, 2025
@JCZuurmond JCZuurmond added this to UCX Jan 22, 2025
@github-project-automation github-project-automation bot moved this to Todo in UCX Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request internal this pull request won't appear in release notes migrate/code Abstract Syntax Trees and other dark magic migrate/python Pull requests that update Python code needs-triage python Pull requests that update Python code
Projects
UCX
Status: Todo
Milestone
No milestone
Development

No branches or pull requests
1 participant
@JCZuurmond