Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TECH DEBT]: Consistently use the DependencyGraphContext #3575

Open
1 task done
JCZuurmond opened this issue Jan 27, 2025 · 0 comments
Open
1 task done

[TECH DEBT]: Consistently use the DependencyGraphContext #3575

JCZuurmond opened this issue Jan 27, 2025 · 0 comments
Labels
needs-triage tech debt chores and design flaws

Comments

@JCZuurmond
Copy link
Member

Is there an existing issue for this?

  • I have searched the existing issues

Problem statement

The DependencyGraphContext is not used consistently

Proposed Solution

Consistently use the DependencyGraphContext where applicable:

  1. DependencyGraph.__init__
  2. WorkflowLinter.__init__
  3. LocalCodeLinter.__init__
  4. Check for other locations when starting working on this issue

Also:

  • Add docstring for the class and its attributes
  • Maybe move the context to the contexts.py module

I think the inconsistent usage arose when the context was introduced but not applied everywhere.

Additional Context

No response

@JCZuurmond JCZuurmond added needs-triage tech debt chores and design flaws labels Jan 27, 2025
@JCZuurmond JCZuurmond added this to UCX Jan 27, 2025
@github-project-automation github-project-automation bot moved this to Todo in UCX Jan 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-triage tech debt chores and design flaws
Projects
Status: Todo
Development

No branches or pull requests

1 participant