Add authors facet (#1316)

* add authors facet

* add test for authors facet

* remove contributorType from creators

Author: bklaing2

app/controllers/datacite_dois_controller.rb

@@ -239,6 +239,7 @@ def index
           licenses_with_missing: :facet_by_license_and_other,
           schema_versions: :facet_by_schema,
           link_checks_status: :facet_by_cumulative_year,
+          authors: :facet_by_authors,
           creators_and_contributors: :facet_by_creators_and_contributors,
           subjects: :facet_by_key,
           fields_of_science: :facet_by_fos,

app/models/doi.rb

@@ -726,6 +726,24 @@ def as_indexed_json(_options = {})
       licenses_with_missing: { terms: { field: "rights_list.rightsIdentifier", size: 10, min_doc_count: 1, missing: "__missing__" } },
       languages: { terms: { field: "language", size: 10, min_doc_count: 1 } },
       certificates: { terms: { field: "client.certificate", size: 10, min_doc_count: 1 } },
+      authors: {
+        terms: {
+          field: "creators.nameIdentifiers.nameIdentifier",
+          size: 10,
+          min_doc_count: 1,
+          include: "https?://orcid.org/.*"
+        },
+        aggs: {
+          authors: {
+            top_hits: {
+              _source: {
+                includes: [ "creators.name", "creators.nameIdentifiers.nameIdentifier"]
+              },
+              size: 1
+            }
+          }
+        }
+      },
       creators_and_contributors: {
         terms: {
           field: "creators_and_contributors.nameIdentifiers.nameIdentifier",

spec/requests/datacite_dois/datacite_dois_spec.rb

@@ -1648,4 +1648,64 @@ def clear_doi_index
       expect(json.dig("meta", "licensesWithMissing", 1, "id")).to eq("__missing__")
     end
   end
+
+  describe "GET /dois search with author values", prefix_pool_size: 1 do
+    let!(:dois) { create_list(:doi, 10, client: client, aasm_state: "findable") }
+    let!(:dois_with_creators) do
+      create_list(:doi, 3, client: client, aasm_state: "findable",
+        creators: [
+          {
+            "name" => "TEST CREATOR 1",
+            "nameIdentifiers" => [
+              {
+                "nameIdentifier" => "https://orcid.org/0000-0003-3484-6874",
+                "nameIdentifierScheme" => "ORCID",
+                "schemeUri" => "https://orcid.org",
+              },
+            ],
+          },
+          {
+            "name" => "TEST CREATOR 2",
+            "nameIdentifiers" => [
+              {
+                "nameIdentifier" => "https://orcid.org/0000-0003-3484-6875",
+                "nameIdentifierScheme" => "ORCID",
+                "schemeUri" => "https://orcid.org",
+              },
+            ],
+          }
+        ]
+      )
+    end
+    let!(:dois_with_contributors) do
+      create_list(:doi, 3, client: client, aasm_state: "findable",
+        contributors: [
+          {
+            "contributorType" => "Editor",
+            "name" => "TEST CONTRIBUTOR",
+            "nameIdentifiers" => [
+              {
+                "nameIdentifier" => "https://orcid.org/0000-0003-3484-6876",
+                "nameIdentifierScheme" => "ORCID",
+                "schemeUri" => "https://orcid.org",
+              },
+            ],
+          }
+        ]
+      )
+    end
+
+    before do
+      clear_doi_index
+      import_doi_index
+    end
+
+    it "returns author values" do
+      get "/dois?facets=authors", nil, headers
+
+      expect(last_response.status).to eq(200)
+      expect(json.dig("meta", "authors")).to be_truthy
+      expect(json.dig("meta", "authors").length()).to eq(3)
+    end
+  end
 end