-
Notifications
You must be signed in to change notification settings - Fork 18
Refactor dim_orgs and incorporate changes into sales_sync #125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| Base branch | Pull Request branch |
| master (1504585) | update-dim_users-dim_orgs (9df55af) |
- Different: 2
- Identical: 1
| DEMO.CORE.SALES_SYNC | ||||||||||||||
Primary keys ORG_ID |
||||||||||||||
| master | update-dim_users-dim... | |||||||||||||
| DIFFERENCES | ||||||||||||||
| Total rows | 4 | ↑ 5 +25.0% | ||||||||||||
| Exclusive PKs | 0 | 1 | ||||||||||||
| View details → | ||||||||||||||
| 2 potential data app dependencies | ||||||||||||||
Unchanged Attributes
|
||||||||||||||
| DEMO.CORE.DIM_ORGS | ||||||||||||||||
Primary keys ORG_ID |
||||||||||||||||
| DIFFERENCES | ||||||||||||||||
3 column(s) with differing values
|
||||||||||||||||
| View details → | ||||||||||||||||
| 18 potential data app dependencies | ||||||||||||||||
Unchanged Attributes
|
||||||||||||||||
| DEMO.CORE.DIM_USERS | ||||||||||||||||||
Primary keys USER_ID |
||||||||||||||||||
| View details → | ||||||||||||||||||
Unchanged Attributes
|
||||||||||||||||||
Skipped Data Diffs of downstream tables: 2
Add "datafold:diff-all-downstream" label to this pull request to diff all affected tables| DEMO.CORE.fct_monthly_financials (table) | Run Data Diff → |
| DEMO.CORE.fct_yearly_financials (table) | Run Data Diff → |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| Base branch | Pull Request branch |
| master (1504585) | update-dim_users-dim_orgs (9df55af) |
- Different: 2
- Identical: 1
| DEMO.CORE.SALES_SYNC | ||||||||||||||
Primary keys ORG_ID |
||||||||||||||
| master | update-dim_users-dim... | |||||||||||||
| DIFFERENCES | ||||||||||||||
| Total rows | 4 | ↑ 5 +25.0% | ||||||||||||
| Exclusive PKs | 0 | 1 | ||||||||||||
| View details → | ||||||||||||||
| 2 potential data app dependencies | ||||||||||||||
Unchanged Attributes
|
||||||||||||||
| DEMO.CORE.DIM_ORGS | ||||||||||||||||
Primary keys ORG_ID |
||||||||||||||||
| DIFFERENCES | ||||||||||||||||
3 column(s) with differing values
|
||||||||||||||||
| View details → | ||||||||||||||||
| 18 potential data app dependencies | ||||||||||||||||
Unchanged Attributes
|
||||||||||||||||
| DEMO.CORE.DIM_USERS | ||||||||||||||||||
Primary keys USER_ID |
||||||||||||||||||
| View details → | ||||||||||||||||||
Unchanged Attributes
|
||||||||||||||||||
- Different: 2
| DEMO.CORE.FCT_MONTHLY_FINANCIALS | ||||||||||||||||
Primary keys DATE_MONTH |
||||||||||||||||
| DIFFERENCES | ||||||||||||||||
1 column(s) with differing values
|
||||||||||||||||
| View details → | ||||||||||||||||
| 4 potential data app dependencies | ||||||||||||||||
Unchanged Attributes
|
||||||||||||||||
Modified upstream modelsmodel.demo.dim_orgs |
||||||||||||||||
| DEMO.CORE.FCT_YEARLY_FINANCIALS | ||||||||||||||||
Primary keys DATE_YEAR |
||||||||||||||||
| DIFFERENCES | ||||||||||||||||
1 column(s) with differing values
|
||||||||||||||||
| View details → | ||||||||||||||||
Unchanged Attributes
|
||||||||||||||||
Modified upstream modelsmodel.demo.dim_orgs |
||||||||||||||||
glebmezh
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, the data diff looks good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| Base branch | Pull Request branch |
| master (1504585) | update-dim_users-dim_orgs (9df55af) |
- Different: 2
- Identical: 1
| DEMO.CORE.SALES_SYNC | ||||||||||||||
Primary keys ORG_ID |
||||||||||||||
| master | update-dim_users-dim... | |||||||||||||
| DIFFERENCES | ||||||||||||||
| Total rows | 4 | ↓ 3 -25.0% | ||||||||||||
| Exclusive PKs | 2 | 1 | ||||||||||||
| View details → | ||||||||||||||
Unchanged Attributes
|
||||||||||||||
| DEMO.CORE.DIM_ORGS | ||||||||||||
Primary keys ORG_ID |
||||||||||||
| master | update-dim_users-dim... | |||||||||||
| DIFFERENCES | ||||||||||||
| Total rows | 157 | ↓ 146 -7.0% | ||||||||||
| Exclusive PKs | 11 | 0 | ||||||||||
2 column(s) with differing values
|
||||||||||||
| View details → | ||||||||||||
| 11 potential data app dependencies | ||||||||||||
Unchanged Attributes
|
||||||||||||
| DEMO.CORE.DIM_USERS | ||||||||||||||||||
Primary keys USER_ID |
||||||||||||||||||
| View details → | ||||||||||||||||||
Unchanged Attributes
|
||||||||||||||||||
Skipped Data Diffs of downstream tables: 2
Add "datafold:diff-all-downstream" label to this pull request to diff all affected tables| DEMO.CORE.fct_monthly_financials (table) | Run Data Diff → |
| DEMO.CORE.fct_yearly_financials (table) | Run Data Diff → |
dim_orgs.created_atdim_orgsmodel is built around the first usersign_upevent, but I noticed we have anorg_createdevent that might make more sense to use.sign_upevents fororg_createdevents in modeldim_orgsdim_orgs.sub_priceto0when the value would benull.dim_orgs.sub_plantoIndividualwhennum_usersis1Individualopportunities in the Sales Sync.num_users.