Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(iceberg): Table desc should allow nested db_name #16414

Merged
merged 1 commit into from
Sep 13, 2024

Conversation

Xuanwo
Copy link
Member

@Xuanwo Xuanwo commented Sep 6, 2024

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

Table desc should allow nested db_name

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

Signed-off-by: Xuanwo <github@xuanwo.io>
@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Sep 6, 2024
@github-actions github-actions bot added the pr-bugfix this PR patches a bug in codebase label Sep 6, 2024
@dosubot dosubot bot added the A-storage Area: databend storage label Sep 6, 2024
@BohuTANG
Copy link
Member

BohuTANG commented Sep 9, 2024

Add some logic tests for the iceberg table?

@Xuanwo
Copy link
Member Author

Xuanwo commented Sep 9, 2024

Add some logic tests for the iceberg table?

Tests will be added as a whole. There are the following PRs to address other issues.

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Sep 13, 2024
@BohuTANG BohuTANG merged commit be0597b into databendlabs:main Sep 13, 2024
95 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-storage Area: databend storage lgtm This PR has been approved by a maintainer pr-bugfix this PR patches a bug in codebase size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants