refactor: cleanup logic to get tables to vacuum #16450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Replace `None` limit with `usize::MAX` to simplify capacity checking logic. - Replace `None` retention time with `DateTime::MAX_UTC`. - Rename `TableInfoFilter` variants to reflect its purpose more precisely.
github-actions
bot
added
the
pr-refactor
dosubot
bot
added
the
size:L
SkyFan2002
approved these changes
Sep 13, 2024
11 tasks
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/
Summary
refactor: cleanup logic to get tables to vacuum
Replace
Nonelimit withusize::MAXto simplify capacity checkinglogic.
Replace
Noneretention time withDateTime::MAX_UTC.Rename
TableInfoFiltervariants to reflect its purpose moreprecisely.
Tests
Type of change
Related Issues
This change is