Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: add KVPbCrudApi as abstraction layer for commonly used CRUD operations #16479

Merged
merged 6 commits into from
Sep 20, 2024

Conversation

drmingdrmer
Copy link
Member

@drmingdrmer drmingdrmer commented Sep 19, 2024

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

chore: remove unused append_update_stream_meta_requests()
refactor: add KVPbCrudApi as abstraction layer for commonly used CRUD operations
chore: simplify SchemaApi::get_table_meta_history()
chore: refactor SchemaApi::create_index()
chore: refactor rename_table()

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Refactoring

Related Issues


This change is Reviewable

@github-actions github-actions bot added the pr-chore this PR only has small changes that no need to record, like coding styles. label Sep 19, 2024
@drmingdrmer drmingdrmer marked this pull request as ready for review September 20, 2024 02:12
@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Sep 20, 2024
@drmingdrmer drmingdrmer changed the title chore: remove unused append_update_stream_meta_requests() refactor: add KVPbCrudApi as abstraction layer for commonly used CRUD operations Sep 20, 2024
@dosubot dosubot bot added the pr-refactor this PR changes the code base without new features or bugfix label Sep 20, 2024
@drmingdrmer drmingdrmer merged commit 207ee9e into databendlabs:main Sep 20, 2024
71 of 72 checks passed
@drmingdrmer drmingdrmer deleted the 141-rename-table branch September 20, 2024 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-chore this PR only has small changes that no need to record, like coding styles. pr-refactor this PR changes the code base without new features or bugfix size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant