Skip to content

Conversation

@asmacdo
Copy link
Member

@asmacdo asmacdo commented Dec 2, 2025

Updated PR description:

Design doc for OCI storage and runtime selection refactor.

Builds on the skopeo OCI image storage PR: #277

Key changes:

  • docker:// URLs store images as OCI directories via Skopeo
  • Versioned storage paths: .datalad/environments/<name>/<version>/image/
  • New --runtime flag on containers-add to select docker/podman/apptainer
  • Runtime preference stored in config, read by OCI shim

URL scheme simplification:

  • docker:// - OCI storage, runtime via --runtime flag
  • shub:// - SIF file, singularity exec
  • Deprecate: oci:docker://, dhub://

Main doc: docs/design/oci-runtime-refactor.md

  • Remove rejected profiles docs, kept in for now for reference

Proposal to separate image storage from execution configuration:
- Clean registry URL scheme (docker://, quay://, ghcr://)
- Native OCI format storage with git-annex tracking
- Execution profiles (YAML) for reusable run configurations
- Profile inheritance with clobber semantics
- CLI overrides (--image, --exec) for flexibility

Builds on the skopeo branch which implements OCI storage.

Includes:
- Main proposal: docs/design/image-container-refactor.md
- ReproNim integration: docs/design/image-container-refactor-repronim.md
- Tutorial: docs/design/tutorial-mriqc-workflow.md
- ReproNim example: docs/design/repronim-containers-mriqc-example.md

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
@codecov
Copy link

codecov bot commented Dec 2, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.88%. Comparing base (db11473) to head (1661295).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #284   +/-   ##
=======================================
  Coverage   93.88%   93.88%           
=======================================
  Files          24       24           
  Lines        1112     1112           
=======================================
  Hits         1044     1044           
  Misses         68       68           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

asmacdo and others added 6 commits December 3, 2025 09:18
Documents:
- URL scheme changes (docker:// now OCI, removed dhub://, oci:, shub://)
- Storage path changes (.datalad/containers/images/<name>/<version>/)
- Execution config removal (cmdexec not set)

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
- Use colon separator for versioning (like Docker tags)
- Document Docker daemon loading and tagging behavior
- Show version defaulting from URL tag
- Update usage examples throughout

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
- Use name:version format (colon separator)
- {img} expands to Docker image name (datalad-container/name:version)
- Show docker run examples instead of apptainer/oci paths

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
- Document both Docker and Apptainer usage patterns
- List all placeholders: {img}, {img_path}, {cmd}
- Note support for multiple runtimes

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
- {img} = Docker image name (datalad-container/name:version)
- {img_path} = OCI directory path
- Update profile examples to use correct placeholders

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
- Mark Phase 3 (Execution Profiles) as complete
- Update examples to use tested docker-default/apptainer-default profiles
- Document implemented features and test commands

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
asmacdo and others added 4 commits December 4, 2025 08:38
- Add "very rough draft" status note
- Document available placeholders: {img}, {img_path}, {cmd}
- Add runtime-only profiles option (no image, require --image)
- Update examples to use name:version format (mriqc:23.1.0)
- Fix placeholder usage: oci:{img_path} for apptainer, {img} for docker
- Add datalad save commands to workflow examples
- Simplify Docker profile example

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
@asmacdo asmacdo changed the title Add design docs for image/profile refactor Design Doc: OCI storage and runtime selection Dec 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant