Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deprecate SHARED_DB #57

Open
fgregg opened this issue Aug 28, 2020 · 5 comments
Open

deprecate SHARED_DB #57

fgregg opened this issue Aug 28, 2020 · 5 comments

Comments

@fgregg
Copy link
Contributor

fgregg commented Aug 28, 2020

since all our the scrapers we are deploying now need the environment variable SHARED_DB, perhaps we should update that as the default path in the pupa_settings.py file and not required SHARED_DB to be set? Thoughts, @hancush ?
@hancush
Copy link
Member

hancush commented Aug 28, 2020

Love this idea. 💯

@fgregg
Copy link
Contributor Author

fgregg commented Aug 28, 2020

we can't quite do it because we still support the OCD API. We should figure out what we want to do about that.

@hancush
Copy link
Member

hancush commented Aug 31, 2020

Are there any active users of the OCD API?

@fgregg
Copy link
Contributor Author

fgregg commented Aug 31, 2020 •
edited
Loading

i think @derekeder might have a better answer to that than me.

@hancush
Copy link
Member

hancush commented Aug 31, 2020

Another thing that comes to mind is, since the scrapers now populate Councilmatic instances directly, is it worth maintaining a standalone OCD API, or could we build an API into Councilmatic instances?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@fgregg @hancush