Google OAuth first_name

[tomgaff]

On initial authentication, the users.first_name field gets populated correctly with only the first name (eg. John), but on subsequent use, the users.first_name is populated with first_name and last_name (eg. John Doe).

In GoogleOauth.php, it looks like it is set based on 2 different values. Any reason for this that I'm overlooking? Or any way to prevent? Feels like it should always be given_name

 if ($nameOfProcess === 'syncingUserInfo') {
...
 $this->config->usersColumnsName['first_name'] => $userInfo->name, //Bad
...
}

compared to

  if ($nameOfProcess === 'newUser') {
...
  $this->config->usersColumnsName['first_name'] => $userInfo->given_name, // Good
...
}

using
datamweb/shield-oauth dev-develop 82f07b6 OAuth for CodeIgniter Shield

[datamweb]

First of all, thank you very much for your careful review and for reporting this 🙏

You are absolutely right — the first_name field should be handled consistently in both processes (newUser and syncingUserInfo). Using given_name is the correct and consistent behavior.

In PR #58 , this was unintentionally overlooked, and during syncingUserInfo it incorrectly uses name (the full name) instead of given_name.

If possible, please feel free to submit a pull request to correct this so it can be reviewed and merged promptly. Your contribution would be greatly appreciated.