[BUZZOK-28553] Load env variables from RuntimeParameters #305
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carsongee
reviewed
Nov 21, 2025
Comment on lines
+124
to
+126
| maybe_set_env_from_runtime_parameters("EXTERNAL_MCP_URL") | ||
| maybe_set_env_from_runtime_parameters("MCP_DEPLOYMENT_ID") | ||
| maybe_set_env_from_runtime_parameters("SESSION_SECRET_KEY") |
Contributor
There was a problem hiding this comment.
Please use the Config class for this, it is built to solve exactly all of these problems. Just add these variables to it and it will automatically load them in from .env, from pulumi exports, and from runtime parameters
Contributor
Author
There was a problem hiding this comment.
@carsongee This is the plan, but we need a short term-fix until the proper implementation is ready.
Contributor
Author
|
This is not needed as the MCP config now uses DataRobotAppFrameworkBaseSettings datarobot-oss/datarobot-genai#44 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This repository is public. Do not put here any private DataRobot or customer's data: code, datasets, model artifacts, .etc.
Summary
Rationale