Fix resource leaks failing tests

Author: k-rus

src/java/org/apache/cassandra/index/sai/SSTableContext.java

@@ -65,7 +65,6 @@ private SSTableContext(SSTableContext copy)
         this.primaryKeyMapFactory = copy.primaryKeyMapFactory;
     }
 
-    @SuppressWarnings("resource")
     public static SSTableContext create(SSTableReader sstable, IndexComponents.ForRead perSSTableComponents)
     {
         var onDiskFormat = perSSTableComponents.onDiskFormat();

src/java/org/apache/cassandra/index/sai/disk/v1/PartitionAwarePrimaryKeyMap.java

@@ -59,8 +59,10 @@ public class PartitionAwarePrimaryKeyMap implements PrimaryKeyMap
     @ThreadSafe
     public static class PartitionAwarePrimaryKeyMapFactory implements Factory
     {
+        private final IndexComponents.ForRead perSSTableComponents;
         private final LongArray.Factory tokenReaderFactory;
         private final LongArray.Factory offsetReaderFactory;
+        private final MetadataSource metadata;
         private final KeyFetcher keyFetcher;
         private final IPartitioner partitioner;
         private final PrimaryKey.Factory primaryKeyFactory;
@@ -74,13 +76,15 @@ public PartitionAwarePrimaryKeyMapFactory(IndexComponents.ForRead perSSTableComp
         {
             try
             {
-                MetadataSource metadata = MetadataSource.loadMetadata(perSSTableComponents);
+                this.perSSTableComponents = perSSTableComponents;
+                this.metadata = MetadataSource.loadMetadata(perSSTableComponents);
+                MetadataSource metadata = MetadataSource.loadMetadata(this.perSSTableComponents);
 
                 IndexComponent.ForRead offsetsComponent = perSSTableComponents.get(IndexComponentType.OFFSETS_VALUES);
                 IndexComponent.ForRead tokensComponent = perSSTableComponents.get(IndexComponentType.TOKEN_VALUES);
 
-                NumericValuesMeta offsetsMeta = new NumericValuesMeta(metadata.get(offsetsComponent));
-                NumericValuesMeta tokensMeta = new NumericValuesMeta(metadata.get(tokensComponent));
+                NumericValuesMeta offsetsMeta = new NumericValuesMeta(this.metadata.get(offsetsComponent));
+                NumericValuesMeta tokensMeta = new NumericValuesMeta(this.metadata.get(tokensComponent));
 
                 count = tokensMeta.valueCount;
                 token = tokensComponent.createFileHandle();

src/java/org/apache/cassandra/index/sai/disk/v2/RowAwarePrimaryKeyMap.java

@@ -71,6 +71,7 @@ public class RowAwarePrimaryKeyMap implements PrimaryKeyMap
     @ThreadSafe
     public static class RowAwarePrimaryKeyMapFactory implements Factory
     {
+        private final IndexComponents.ForRead perSSTableComponents;
         private final LongArray.Factory tokenReaderFactory;
         private final SortedTermsReader sortedTermsReader;
         private final long count;
@@ -88,6 +89,7 @@ public RowAwarePrimaryKeyMapFactory(IndexComponents.ForRead perSSTableComponents
         {
             try
             {
+                this.perSSTableComponents = perSSTableComponents;
                 MetadataSource metadataSource = MetadataSource.loadMetadata(perSSTableComponents);
                 NumericValuesMeta tokensMeta = new NumericValuesMeta(metadataSource.get(perSSTableComponents.get(IndexComponentType.TOKEN_VALUES)));
                 count = tokensMeta.valueCount;