Skip to content

Commit d89cb20

Browse files
committed
Fix some things
1 parent d86302e commit d89cb20

File tree

6 files changed

+771
-367
lines changed

6 files changed

+771
-367
lines changed

config/storybook.main.template.js

Lines changed: 7 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
1+
const { resolve } = require('path');
2+
13
/**
24
* @type {import('storybook-react-rsbuild').StorybookConfig}
35
*/
@@ -7,33 +9,14 @@ module.exports = {
79
'@storybook/addon-links',
810
'@storybook/addon-essentials',
911
'@storybook/addon-interactions',
10-
{
11-
name: '@storybook/addon-styling-webpack',
12-
options: {
13-
// This is our best guess to replicate the style config we are using in the rspack.config.js
14-
scssBuildRule: {
15-
test: /\.scss$/,
16-
use: [
17-
'style-loader',
18-
{
19-
loader: 'css-loader',
20-
options: { importLoaders: 1 },
21-
},
22-
'resolve-url-loader',
23-
{
24-
loader: 'sass-loader',
25-
options: {
26-
sourceMap: true,
27-
},
28-
},
29-
],
30-
},
31-
},
32-
},
33-
'storybook-addon-swc',
3412
],
3513
framework: {
3614
name: 'storybook-react-rsbuild',
15+
options: {
16+
builder: {
17+
rsbuildConfigPath: resolve(__dirname, './storybook.rsbuild.config.ts'),
18+
},
19+
},
3720
},
3821
rsbuildFinal: async (config) => {
3922
const reactDocgenLoaderRule = config.tools.rspack[1].module.rules[0];

config/storybook.rsbuild.config.ts

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,8 @@
1+
import { defineConfig } from '@rsbuild/core';
2+
import { pluginReact } from '@rsbuild/plugin-react';
3+
import { pluginSass } from '@rsbuild/plugin-sass';
4+
5+
// This is the rsbuild configuration used by storybook, it is not the same as the rspack config!
6+
export default defineConfig({
7+
plugins: [pluginReact(), pluginSass()],
8+
});

package.json

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -39,6 +39,9 @@
3939
"@rspack/core": "~1.1.1",
4040
"@rspack/plugin-minify": "~0.7.5",
4141
"@rspack/plugin-react-refresh": "~1.0.0",
42+
"@rsbuild/core": "^1.1.10",
43+
"@rsbuild/plugin-react": "^1.1.0",
44+
"@rsbuild/plugin-sass": "^1.1.2",
4245
"@swc/core": "~1.9.2",
4346
"@swc/helpers": "~0.5.15",
4447
"@swc/jest": "~0.2.37",

tests_fixtures/standalone_template/.storybook/preview.jsx

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@ import '../workspace.scss';
44
* @type {import('@storybook/react').Parameters}
55
*/
66
export const parameters = {
7-
actions: { argTypesRegex: '^on[A-Z].*' },
87
layout: 'fullscreen',
98
controls: {
109
matchers: {

tests_fixtures/standalone_template/package.json

Lines changed: 10 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -57,21 +57,18 @@
5757
"visyn_scripts": "portal:../../"
5858
},
5959
"devDependencies": {
60-
"@rsbuild/core": "^1.1.1",
61-
"@rsbuild/plugin-react": "^1.0.7",
62-
"@storybook/addon-actions": "^8.4.2",
63-
"@storybook/addon-essentials": "^8.4.2",
64-
"@storybook/addon-interactions": "^8.4.2",
65-
"@storybook/addon-links": "^8.4.2",
66-
"@storybook/addon-styling-webpack": "^1.0.1",
67-
"@storybook/cli": "^8.4.2",
68-
"@storybook/react": "^8.4.2",
69-
"@storybook/react-webpack5": "^8.4.2",
70-
"@storybook/testing-library": "0.2.2",
60+
"@storybook/addon-actions": "^8.4.7",
61+
"@storybook/addon-essentials": "^8.4.7",
62+
"@storybook/addon-interactions": "^8.4.7",
63+
"@storybook/addon-links": "^8.4.7",
64+
"@storybook/blocks": "8.4.7",
65+
"@storybook/cli": "^8.4.7",
66+
"@storybook/react": "^8.4.7",
67+
"@storybook/react-webpack5": "^8.4.7",
7168
"@types/react": "18.3.12",
7269
"@types/react-dom": "^18.3.1",
73-
"storybook": "^8.4.2",
74-
"storybook-react-rsbuild": "^0.1.4"
70+
"storybook": "^8.4.7",
71+
"storybook-react-rsbuild": "^0.1.6"
7572
},
7673
"resolutions": {
7774
"visyn_scripts": "portal:../../"

0 commit comments

Comments
 (0)