From 5a08137b5726caf2879682d85eec44cb00ceffa0 Mon Sep 17 00:00:00 2001 From: Igor Rigolon Date: Tue, 12 Dec 2023 16:36:13 -0300 Subject: [PATCH] update cran-comments with check results --- cran-comments.md | 51 ++++++++++++++++++++++-------------------------- 1 file changed, 23 insertions(+), 28 deletions(-) diff --git a/cran-comments.md b/cran-comments.md index 43fb916..5317c4d 100644 --- a/cran-comments.md +++ b/cran-comments.md @@ -1,40 +1,35 @@ -# New submission - - - -# Previous CRAN comments - -Since our previous submission, we have added many new functions and changed the way most pre-existing functions work. We have change http to https. - ## Test environments - R-hub windows-x86_64-devel (r-devel) +- R-hub ubuntu-gcc-release (r-release) +- R-hub fedora-clang-devel (r-devel) ## R CMD check results -0 errors ✔ | 0 warnings ✔ | 0 notes ✔ -GitHub Actions checks on Windows, MacOS, and Linux also return no errors, warnings, or notes. +0 errors ✔ | 0 warnings ✔ | 6 notes ✖ -## R CMD check results -> On windows-x86_64-devel (r-devel), ubuntu-gcc-release (r-release), fedora-clang-devel (r-devel) - checking CRAN incoming feasibility ... NOTE - Maintainer: 'Francisco de Lima Cavalcanti ' +There are four distinct notes across the platforms: + + * Our maintainer has changed - New submission + * checking for non-standard things in the check directory ... NOTE + Found the following files/directories: + ''NULL'' + + * checking for detritus in the temp directory ... NOTE + Found the following files/directories: + 'lastMiKTeXException' - Package was archived on CRAN + * checking HTML version of manual ... NOTE + Skipping checking HTML validation: no command 'tidy' found - CRAN repository db overrides: - X-CRAN-Comment: Archived on 2022-01-23 for policy violation. +Seem to be common and harmless, not sure of the cause. - Maintainer is a not a single person. Also, reauires flaky packages - sidrdr and geobr. + * Found the following (possibly) invalid URLs: + URL: https://dadosabertos.aneel.gov.br/dataset/relacao-de-empreendimentos-de-geracao-distribuida + From: inst/doc/ANEEL.html + README.md + Status: 403 + Message: Forbidden - * Maintainer has been changed and package is no longer dependent on the (now archived) package 'geobr'. +The URL works for us. -> On windows-x86_64-devel (r-devel) - checking for detritus in the temp directory ... NOTE - Found the following files/directories: - 'lastMiKTeXException' - - * Seems to be a common note, but it doesn't appear on other checks besides `devtools::check_win_devel()` and `rhub::check_for_cran()`. - * GitHub Actions checks and local `devtools::check()` display no errors, warnings, or notes.