What do you think about my Downloads extension?

[adegans]

I made a downloads plugin for Yellow.

Available here: https://github.com/adegans/yellow-downloads
See it in action here (any of the posts): https://www.arnan.me/blog/tag:gpx/

[schulle4u]

Hello Arnan,

Thanks for the new Yellow extension. Maybe you could add a download counter and a checksum calculation to the shortcut?

Here's some more general feedback, in no particular order:

• Make yourself familiar with our coding and documentation standards as suggested in the self-review checklist. Especially:
  • Write the name and repository URL as single-line comment right after the opening <?php tag (e.g. // Downloads extension, https://github.com/adegans/yellow-downloads).
  • Your indentation looks a little messy at the moment, tabs and spaces are wildly mixed. 🙂
  • Use Status: experimental in your installation settings for extensions which are not yet available via the website.
• I suggest to thread multiple files as one quoted shortcut argument rather than parsing the whole settings array, e.g. [download "file1.zip file2.zip file3.zip"]. This allows to define more arguments for the actual shortcut in the future, e.g. style class.
• Define shourtcut texts as language settings (file, size, uploaded) to make them translatable in other languages.

So far for the moment, hope this helps. Happy coding! 😀

Steffen

[adegans]

I've updated the plugin with your suggestions. Also the tagcloud plugin I announced in another thread.

A style class is not necessary as people can just apply CSS to the class that's already there. I've added that to the readme.md, which class to use and such.