-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
.cljc conversion for ClojureScript use #12
Comments
This is effectively done, over on this branch: https://github.com/cemerick/dorothy/tree/cljc I'll not open a PR before hearing re: whether the split of rendering stuff into a dedicated namespace is acceptable. Either way, I'll then update the documentation and such before then opening a PR. |
Hey Chas. I'm totally open to these changes. I trust your judgement and since I haven't really worked on or used this code in quite a while, I don't really have a strong opinion. Would the upgrade path for existing code just be changing a |
Yup, it'd be changing e.g.: (ns foo
(:require [dorothy.core :as dot :refer (render)])) to: (ns foo
(:require [dorothy.core :as dot]
[dorothy.jvm :refer (render)]))) |
Works for me. |
Opened the PR. Some things you'll need to do I can't:
I'm now using the results of this with some nontrivial graphs, and it all looks 👍 FWIW |
Looks like this will be pretty straightforward.
My preference would be to move the rendering bits into a new
dorothy.jvm
namespace. That's obviously a breaking change, but it would leave room for node- and browser-specific namespaces for rendering in those environments later. If you'd prefer not to do that, let me know and I'll keep the jvm rendering stuff where it is.The text was updated successfully, but these errors were encountered: