Skip to content

Commit 08ac02b

Browse files
daviddentondaviddenton
committed
Fix #46.
1 parent cc2f705 commit 08ac02b

File tree

9 files changed

+21
-18
lines changed

9 files changed

+21
-18
lines changed

‎CHANGELOG.md

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,9 @@ The main API is stable, but expect some amount of breaking changes around major
77
- Add strict `Accept` header checking for `RouteSpec`s based on `producing()` settings. Option for non-strictness.
88
- Add integrated self-hosted Swagger UI/ReDoc UI module
99

10+
## 14.21.2
11+
- Fix #46 - ETags should be wrapped in quotes.
12+
1013
## 14.21.1
1114
- Upgrade Finagle to new version
1215

‎README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ To activate the extension library features (JSON, templates etc), additional dep
4444
Add the following lines to ```build.sbt``` - the lib is hosted in Maven Central and JCenter:
4545
```scala
4646
resolvers += "JCenter" at "https://jcenter.bintray.com"
47-
libraryDependencies += "io.fintrospect" %% "fintrospect-core" % "14.21.1"
47+
libraryDependencies += "io.fintrospect" %% "fintrospect-core" % "14.21.2"
4848
```
4949

5050
## See the code

‎build.sbt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
lazy val baseSettings = Seq(
22
name := "fintrospect",
33
organization := "io.fintrospect",
4-
version := "14.21.1",
4+
version := "14.21.2",
55
scalaVersion := "2.12.3",
66
crossScalaVersions := Seq("2.12.3", "2.11.8"),
77
licenses := Seq("Apache-2.0" -> url("http://www.apache.org/licenses/LICENSE-2.0")),

‎core/src/main/scala/io/fintrospect/filters/Caching.scala

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -100,7 +100,7 @@ object Caching {
100100
rsp => {
101101
if (predicate(rsp)) {
102102
val hashedBody = getInstance("MD5").digest(extract(rsp.content)).map("%02x".format(_)).mkString
103-
rsp.headerMap(ETAG) = hashedBody
103+
rsp.headerMap(ETAG) = s""""$hashedBody""""
104104
}
105105
rsp
106106
}

‎core/src/test/scala/io/fintrospect/filters/CachingTest.scala

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -98,7 +98,7 @@ class CachingTest extends FunSpec with Matchers {
9898
it("adds when predicate succeeds") {
9999
val response = Response()
100100
response.contentString = "bob"
101-
result(Caching.Response.AddETag[Request](_ => true)(Request(), Service.mk { req => Future(response) })).headerMap("ETag") shouldBe "9f9d51bc70ef21ca5c14f307980a29d8"
101+
result(Caching.Response.AddETag[Request](_ => true)(Request(), Service.mk { req => Future(response) })).headerMap("ETag") shouldBe """"9f9d51bc70ef21ca5c14f307980a29d8""""
102102
}
103103

104104
it("does not add when predicate fails") {

‎harp.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
11
{
22
"globals": {
33
"fintrospect": {
4-
"old": "14.21.0",
5-
"new": "14.21.1"
4+
"old": "14.21.1",
5+
"new": "14.21.2"
66
}
77
}
88
}

‎src/main/site/format-dependencies.md

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -14,19 +14,19 @@
1414
<tr>
1515
<td><a href="http://argonaut.io/">Argonaut</a></td>
1616
<td>application/json</td>
17-
<td>"io.fintrospect" %% "fintrospect-argonaut" % "14.21.1"</td>
17+
<td>"io.fintrospect" %% "fintrospect-argonaut" % "14.21.2"</td>
1818
<td><a data-toggle="tooltip" href="#" title="io.fintrospect.formats.Argonaut">Argonaut</a></td>
1919
</tr>
2020
<tr>
2121
<td><a href="https://github.com/travisbrown/circe">Circe</a></td>
2222
<td>application/json</td>
23-
<td>"io.fintrospect" %% "fintrospect-circe" % "14.21.1"</td>
23+
<td>"io.fintrospect" %% "fintrospect-circe" % "14.21.2"</td>
2424
<td><a data-toggle="tooltip" href="#" title="io.fintrospect.formats.Circe">Circe</a></td>
2525
</tr>
2626
<tr>
2727
<td><a href="https://github.com/google/gson">GSON</a></td>
2828
<td>application/json</td>
29-
<td>"io.fintrospect" %% "fintrospect-gson" % "14.21.1"</td>
29+
<td>"io.fintrospect" %% "fintrospect-gson" % "14.21.2"</td>
3030
<td><a data-toggle="tooltip" href="#" title="io.fintrospect.formats.Gson">Gson</a></td>
3131
</tr>
3232
<tr>
@@ -38,22 +38,22 @@
3838
<tr>
3939
<td><a href="https://github.com/FasterXML/jackson">Jackson</a> </td>
4040
<td>application/json</td>
41-
<td>"io.fintrospect" %% "fintrospect-jackson" % "14.21.1"</td>
41+
<td>"io.fintrospect" %% "fintrospect-jackson" % "14.21.2"</td>
4242
<td>
4343
<a data-toggle="tooltip" href="#" title="io.fintrospect.formats.Jackson">Jackson</a>
4444
</tr>
4545
<tr>
4646
<td><a href="http://json4s.org/">Json4S Native</a></td>
4747
<td>application/json</td>
48-
<td>"io.fintrospect" %% "fintrospect-json4s" % "14.21.1"</td>
48+
<td>"io.fintrospect" %% "fintrospect-json4s" % "14.21.2"</td>
4949
<td><a data-toggle="tooltip" href="#" title="io.fintrospect.formats.Json4s">Json4s</a>
5050
<br/>
5151
<a data-toggle="tooltip" href="#" title="io.fintrospect.formats.Json4sDoubleMode">Json4sDoubleMode</a></td>
5252
</tr>
5353
<tr>
5454
<td><a href="http://json4s.org/">Json4S Jackson</a> </td>
5555
<td>application/json</td>
56-
<td>"io.fintrospect" %% "fintrospect-json4s" % "14.21.1"</td>
56+
<td>"io.fintrospect" %% "fintrospect-json4s" % "14.21.2"</td>
5757
<td>
5858
<a data-toggle="tooltip" href="#" title="io.fintrospect.formats.Json4sJackson">Json4sJackson</a>
5959
<br/>
@@ -62,7 +62,7 @@
6262
<tr>
6363
<td><a href="http://msgpack.org">MsgPack</a></td>
6464
<td>application/msgpack</td>
65-
<td>"io.fintrospect" %% "fintrospect-msgpack" % "14.21.1"</td>
65+
<td>"io.fintrospect" %% "fintrospect-msgpack" % "14.21.2"</td>
6666
<td><a data-toggle="tooltip" href="#" title="io.fintrospect.formats.MsgPack">MsgPack</a></td>
6767
</tr>
6868
<tr>
@@ -74,13 +74,13 @@
7474
<tr>
7575
<td><a href="https://www.playframework.com">Play</a></td>
7676
<td>application/json</td>
77-
<td>"io.fintrospect" %% "fintrospect-play" % "14.21.1"</td>
77+
<td>"io.fintrospect" %% "fintrospect-play" % "14.21.2"</td>
7878
<td><a data-toggle="tooltip" href="#" title="io.fintrospect.formats.Play">Play</a></td>
7979
</tr>
8080
<tr>
8181
<td><a href="https://github.com/spray/spray-json">Spray</a></td>
8282
<td>application/json</td>
83-
<td>"io.fintrospect" %% "fintrospect-spray" % "14.21.1"</td>
83+
<td>"io.fintrospect" %% "fintrospect-spray" % "14.21.2"</td>
8484
<td><a data-toggle="tooltip" href="#" title="io.fintrospect.formats.Spray">Spray</a></td>
8585
</tr>
8686
<tr>

‎src/main/site/installation-header.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,5 +9,5 @@ To activate some optional features, additional dependencies may be required - th
99
Add the following lines to ```build.sbt``` - the lib is hosted in Maven Central and JCenter:
1010
```scala
1111
resolvers += "JCenter" at "https://jcenter.bintray.com"
12-
libraryDependencies += "io.fintrospect" %% "fintrospect-core" % "14.21.1"
12+
libraryDependencies += "io.fintrospect" %% "fintrospect-core" % "14.21.2"
1313
```

‎src/main/site/templating-dependencies.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,13 +8,13 @@
88
<tr>
99
<td><a href="http://handlebarsjs.com">Handlebars</a></td>
1010
<td>.hbs</td>
11-
<td>"io.fintrospect" %% "fintrospect-handlebars" % "14.21.1"</td>
11+
<td>"io.fintrospect" %% "fintrospect-handlebars" % "14.21.2"</td>
1212
<td><a data-toggle="tooltip" href="#" title="io.fintrospect.templating.HandlebarsTemplates">HandlebarsTemplates</a></td>
1313
</tr>
1414
<tr>
1515
<td><a href="http://mustache.github.io/">Mustache</a></td>
1616
<td>.mustache</td>
17-
<td>"io.fintrospect" %% "fintrospect-mustache" % "14.21.1"</td>
17+
<td>"io.fintrospect" %% "fintrospect-mustache" % "14.21.2"</td>
1818
<td><a data-toggle="tooltip" href="#" title="io.fintrospect.templating.MustacheTemplates">MustacheTemplates</a></td>
1919
</tr>
2020
</table>

0 commit comments

Comments
 (0)