View controllers can be proxied more than once

[sixten]

After spending a couple of hours trying to track down an issue in my app where a link on one tab wouldn't take you to a different tab reliably, the proximate cause seems to be that -[NKNavigatorMap objectForURL:query:pattern:] could wrap a controller in more than one layer of NKViewControllerProxy.

Specifically, because the proxy forwards messages to the "real" object, this will evaluate to true:

if ([object isKindOfClass:[UIViewController class]] &&
  ![object isKindOfClass:[NKViewController class]]) {

I've added an additional clause that seems to have alleviated the issue:

if ([object isKindOfClass:[UIViewController class]] &&
  ![object isKindOfClass:[NKViewController class]] &&
  ![[object class] isSubclassOfClass:[NKViewControllerProxy class]]) {

[davidmorford]

Ouch! Good catch. Will merge and fix when I get back from WWDC this weekend.