fix(remove_keras_spec): Prevent aggressive model removal
#31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| expect_true(exists(model_name_2, inherits = FALSE)) | ||
| expect_no_error(parsnip:::check_model_doesnt_exist(model_name)) | ||
| expect_error(parsnip:::check_model_doesnt_exist(model_name_2)) | ||
|
|
There was a problem hiding this comment.
[air] reported by reviewdog 🐶
Suggested change
|
|
||
| # cleanup | ||
| remove_keras_spec(model_name_2) | ||
| }) |
There was a problem hiding this comment.
[air] reported by reviewdog 🐶
Suggested change
| }) | |
| }) |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes a bug in
remove_keras_specthat caused the function to delete multiple models if their names shared a common prefix.The fix replaces the broad regex matching with a more specific approach. It now generates a list of exact object names to remove by combining the model name with a set of predefined suffixes (
_args,_encoding,_fit, etc.). This ensures that only the objects directly related to the specified model are removed.Changes
tests/testthat/test_e2e_spec_removal.Rto verify that the function no longer removes models with similar names.remove_keras_specinR/remove_keras_spec.Rto use a more specific method for identifying objects to delete.This change makes the
remove_keras_specfunction safer and more predictable.